Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/rm core dependency cli #974

Merged
merged 6 commits into from
Aug 23, 2024
Merged

Conversation

emrgnt-cmplxty
Copy link
Contributor

@emrgnt-cmplxty emrgnt-cmplxty commented Aug 23, 2024

🚀 This description was created by Ellipsis for commit b6d139d

Summary:

This PR removes the core dependency from the CLI by modifying run_docker_serve in py/cli/utils/docker_utils.py, updates pyproject.toml to version 0.3.01, adds python-dotenv, and corrects a link in py/README.md.

Key points:

  • Removed client parameter from run_docker_serve in py/cli/utils/docker_utils.py.
  • Removed R2RConfig and R2RBuilder dependencies from run_docker_serve.
  • Updated pyproject.toml to version 0.3.01.
  • Added python-dotenv dependency in pyproject.toml.
  • Fixed link description in py/README.md for Group Permissions.

Generated with ❤️ by ellipsis.dev

@emrgnt-cmplxty emrgnt-cmplxty marked this pull request as ready for review August 23, 2024 23:58
@emrgnt-cmplxty emrgnt-cmplxty merged commit 00d6c19 into main Aug 23, 2024
0 of 5 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to b6d139d in 13 seconds

More details
  • Looked at 118 lines of code in 5 files
  • Skipped 1 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. py/pyproject.toml:8
  • Draft comment:
    The version number '0.3.01' is incorrectly formatted. Consider using '0.3.1' to follow semantic versioning.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The version number in the pyproject.toml file is incorrectly formatted. It should follow semantic versioning, which typically uses three numbers separated by dots, e.g., '0.3.1'.
2. py/sdk/models.py:550
  • Draft comment:
    Add a newline at the end of the file for better compatibility with various tools and editors.
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The newline at the end of the file is missing in sdk/models.py. This is a minor issue but it's a good practice to have a newline at the end of files.

Workflow ID: wflow_8NulMaYdn4aAUrnW


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@emrgnt-cmplxty emrgnt-cmplxty deleted the feature/rm-core-dependency-cli branch August 26, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant