Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docker build action #972

Merged
merged 1 commit into from
Aug 23, 2024
Merged

Update docker build action #972

merged 1 commit into from
Aug 23, 2024

Conversation

NolanTrem
Copy link
Collaborator

@NolanTrem NolanTrem commented Aug 23, 2024

🚀 This description was created by Ellipsis for commit a26ba81

Summary:

Updated Docker build action to change working directory and Dockerfile paths in .github/workflows/build-main.yml.

Key points:

  • Updated .github/workflows/build-main.yml to set working-directory to py for build-and-publish job.
  • Changed Dockerfile path from ./py/Dockerfile to Dockerfile in docker/build-push-action step.
  • Changed Dockerfile path from ./py/Dockerfile.unstructured to Dockerfile.unstructured in docker/build-push-action step.

Generated with ❤️ by ellipsis.dev

@NolanTrem NolanTrem merged commit 479a3f4 into main Aug 23, 2024
1 check failed
@NolanTrem NolanTrem deleted the Nolan/UpdateDockerBuild branch August 23, 2024 22:53
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to a26ba81 in 11 seconds

More details
  • Looked at 33 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. .github/workflows/build-main.yml:82
  • Draft comment:
    The context path should be relative to the working directory. Since the working directory is set to 'py', the context should be './'.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_dewQxvLlDlXEIBEe


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@@ -67,7 +70,7 @@ jobs:
uses: docker/build-push-action@v5
with:
context: .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The context path should be relative to the working directory. Since the working directory is set to 'py', the context should be './'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant