Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/rm print cruft rebase #951

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

emrgnt-cmplxty
Copy link
Contributor

@emrgnt-cmplxty emrgnt-cmplxty commented Aug 23, 2024

🚀 This description was created by Ellipsis for commit 2612943

Summary:

This PR removes the user_email parameter from the refresh_access_token function, updates configuration files, and makes minor documentation and formatting adjustments.

Key points:

  • Removed user_email parameter from refresh_access_token in py/core/base/providers/auth.py, py/core/main/api/routes/auth/base.py, py/core/main/services/auth_service.py, and py/core/providers/auth/r2r_auth.py.
  • Renamed .pre-commit-config.yaml from py/.pre-commit-config.yaml to root directory.
  • Updated image URL in py/README.md to use a direct GitHub link.
  • Added isort configuration to py/pyproject.toml.
  • Minor whitespace and formatting adjustments in py/.dockerignore, py/Dockerfile.unstructured, and py/r2r.toml.

Generated with ❤️ by ellipsis.dev

@emrgnt-cmplxty emrgnt-cmplxty marked this pull request as ready for review August 23, 2024 14:43
@emrgnt-cmplxty emrgnt-cmplxty merged commit ac1dda5 into feature/rm-print-cruft Aug 23, 2024
0 of 3 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 2612943 in 24 seconds

More details
  • Looked at 196 lines of code in 12 files
  • Skipped 2 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. py/core/base/providers/auth.py:93
  • Draft comment:
    The refresh_access_token method no longer requires the user_email parameter. Ensure that all calls to this method are updated accordingly to prevent errors. This change is also reflected in auth_service.py, r2r_auth.py, and base.py.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    The comment is informative and suggests ensuring that all calls to the method are updated, which is not actionable in the context of this file alone. It also references changes in other files, which is outside the scope of this review. The comment does not suggest a specific code change within this file.
    The comment does not provide a specific action to be taken within this file and references other files, which is not relevant to the current review. It is more of a reminder than a directive for a code change.
    The comment could be useful for someone reviewing the entire codebase, but it does not align with the rules for commenting on this specific file.
    The comment should be removed as it does not suggest a specific code change within this file and references other files, which is outside the scope of this review.
2. py/.dockerignore:20
  • Draft comment:
    Add a newline at the end of the file. This issue is also present in .github/workflows/build-mainv2.yml and r2r.toml.
  • Reason this comment was not posted:
    Confidence changes required: 20%
    The newline at the end of the file is missing in several files. This is a minor issue but should be corrected for consistency and to avoid potential issues with certain tools or systems that expect a newline at the end of files.
3. py/core/providers/auth/r2r_auth.py:199
  • Draft comment:
    The create_refresh_token method signature includes a data parameter that is no longer used. Consider removing it to avoid confusion.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The create_refresh_token method in r2r_auth.py no longer requires the data parameter, but the method signature still includes it. This should be removed to avoid confusion and potential errors.

Workflow ID: wflow_C3NaZGGLnTncUv1s


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant