Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/revive integration tests (#1343) #1346

Merged
merged 4 commits into from
Oct 5, 2024
Merged

Feature/revive integration tests (#1343) #1346

merged 4 commits into from
Oct 5, 2024

Conversation

emrgnt-cmplxty
Copy link
Contributor

@emrgnt-cmplxty emrgnt-cmplxty commented Oct 5, 2024

  • add postgres to integration

  • add postgres to integration

  • up

  • rename

  • hardcode

  • add back postgres

  • add back postgres

  • add pgvector

  • add pgvector

  • add pgvector

  • add pgvector

  • add pgvector

  • add pgvector

  • add pgvector

  • tweak config docs

  • fix integration suite

  • fix integration suite

  • fix integration suite

  • up

  • up

  • up

  • up

  • up

  • up

  • up

  • up

  • up

  • update integration test

  • final user tests

  • final user tests


Important

Revive integration tests by adding PostgreSQL and pgvector support, updating configurations, and enhancing test coverage.

  • Integration Tests:
    • Add PostgreSQL and pgvector to integration-test-workflow-debian.yml.
    • Update integration tests in harness_cli.py and harness_sdk.py to cover ingestion, search, and user management.
  • Configuration:
    • Update r2r.toml and other config files to reflect new chunking strategy and PostgreSQL settings.
    • Change concurrent_request_limit to 256 in r2r.toml and r2r_aws_bedrock.toml.
  • Code Changes:
    • Modify create_ingestion_provider() in factory.py to handle IngestionConfig as a dictionary.
    • Update get_user_app() in auth_router.py to use UUID for user_id.
    • Adjust PostgresRelationalDBProvider and PostgresVectorDBProvider to use semaphores for connection management.
  • Miscellaneous:
    • Fix typos and update docstrings in various files.
    • Add new test cases in r2rClientIntegrationSuperUser.test.ts for collection management.

This description was created by Ellipsis for 2df2e8a. It will automatically update as commits are pushed.

emrgnt-cmplxty and others added 3 commits October 4, 2024 21:36
* add postgres to integration

* add postgres to integration

* up

* rename

* hardcode

* add back postgres

* add back postgres

* add pgvector

* add pgvector

* add pgvector

* add pgvector

* add pgvector

* add pgvector

* add pgvector

* tweak config docs

* fix integration suite

* fix integration suite

* fix integration suite

* up

* up

* up

* up

* up

* up

* up

* up

* up

* update integration test

* final user tests

* final user tests
…sary error on deletion (#1344)

* Don't throw an error when deleting a collection with no documents, fix return on create collection, more js tests

* Revert "Don't throw an error when deleting a collection with no documents, fix return on create collection, more js tests"

This reverts commit f9f6ead.

* Don't throw an error when deleting a collection with no documents, fix return on create collection, more js tests

* more
* try

* up

* up

* space

* add it in ingestion

* rm ingestion

* init

* add semaphore

* test

* rm duplicates

* kg_creation_settings

* rm semaphores

* increase conns

* change it back

* clean

* up

* up

* up

* up

---------

Co-authored-by: --global=Shreyas Pimpalgaonkar <[email protected]>
Co-authored-by: emrgnt-cmplxty <[email protected]>
@emrgnt-cmplxty emrgnt-cmplxty marked this pull request as ready for review October 5, 2024 05:39
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 2fb8fd7 in 46 seconds

More details
  • Looked at 2201 lines of code in 38 files
  • Skipped 1 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. py/tests/integration/harness_cli.py:145
  • Draft comment:
    The print statement should indicate that this is a hybrid search test, not a vector search test.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The test function test_hybrid_search_sample_file_filter_cli is incorrectly labeled as testing vector search instead of hybrid search. This could lead to confusion when reading the test logs or debugging.
2. py/tests/integration/harness_cli.py:186
  • Draft comment:
    Consider implementing JSON parsing for the RAG response to improve test robustness and maintainability.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The test function test_rag_response_sample_file_cli has a TODO comment indicating a potential improvement to parse JSON output. This should be addressed to ensure the test is robust and maintainable.
3. py/tests/integration/harness_sdk.py:272
  • Draft comment:
    Avoid reassigning the response variable. Use a different variable name for accumulating the response content.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The test function test_rag_response_stream_sample_file_sdk reassigns the response variable, which can lead to confusion and potential bugs. It's better to use a different variable name for the accumulated response.
4. py/tests/integration/harness_sdk.py:348
  • Draft comment:
    Use output instead of response_content in the final check to match the accumulated content variable.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    In the function test_agent_stream_sample_file_sdk, the variable response is used to accumulate content, but the final check uses response_content, which is undefined. This is likely a typo and should be corrected.

Workflow ID: wflow_f9rKHXcq1zeYIH81


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

vercel bot commented Oct 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yc_demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2024 5:47am
yc-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2024 5:47am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
recommendation_platform ⬜️ Ignored (Inspect) Oct 5, 2024 5:47am

@emrgnt-cmplxty emrgnt-cmplxty merged commit fbd910a into main Oct 5, 2024
8 of 12 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 2df2e8a in 26 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_JWrEU9HZSf4pBimc


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants