Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/revive integration tests (#1343) #1345

Merged
merged 1 commit into from
Oct 5, 2024
Merged

Feature/revive integration tests (#1343) #1345

merged 1 commit into from
Oct 5, 2024

Conversation

emrgnt-cmplxty
Copy link
Contributor

@emrgnt-cmplxty emrgnt-cmplxty commented Oct 5, 2024

  • add postgres to integration

  • add postgres to integration

  • up

  • rename

  • hardcode

  • add back postgres

  • add back postgres

  • add pgvector

  • add pgvector

  • add pgvector

  • add pgvector

  • add pgvector

  • add pgvector

  • add pgvector

  • tweak config docs

  • fix integration suite

  • fix integration suite

  • fix integration suite

  • up

  • up

  • up

  • up

  • up

  • up

  • up

  • up

  • up

  • update integration test

  • final user tests

  • final user tests


Important

Revive and enhance integration tests with PostgreSQL support, update configurations, and implement CLI and SDK tests for R2R.

  • Integration Tests:
    • Revive and enhance integration tests in integration-test-workflow-debian.yml.
    • Add PostgreSQL and pgvector support for integration tests.
    • Implement CLI tests in harness_cli.py for ingestion, document overview, and search functionalities.
    • Implement SDK tests in harness_sdk.py for ingestion, document management, and user authentication.
  • Configuration:
    • Update r2r_aws_bedrock.toml to reflect new ingestion and completion settings.
    • Modify docker.mdx to update Docker start command for local LLMs.
  • Code Changes:
    • Update auth_router.py and ingestion_router.py to handle new authentication and ingestion logic.
    • Modify factory.py to support new provider configurations.
    • Adjust auth_service.py to improve user management and authentication processes.
  • Models:
    • Update responses.py to include optional task_id in IngestionResponse.
  • Testing:
    • Add fixtures in conftest.py for database and authentication setup.
    • Include tests for embedding providers in test_litellm_embedding_provider.py.

This description was created by Ellipsis for f7b3f60. It will automatically update as commits are pushed.

* add postgres to integration

* add postgres to integration

* up

* rename

* hardcode

* add back postgres

* add back postgres

* add pgvector

* add pgvector

* add pgvector

* add pgvector

* add pgvector

* add pgvector

* add pgvector

* tweak config docs

* fix integration suite

* fix integration suite

* fix integration suite

* up

* up

* up

* up

* up

* up

* up

* up

* up

* update integration test

* final user tests

* final user tests
@emrgnt-cmplxty emrgnt-cmplxty marked this pull request as ready for review October 5, 2024 05:32
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to f7b3f60 in 1 minute and 6 seconds

More details
  • Looked at 1840 lines of code in 24 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. py/shared/api/models/ingestion/responses.py:16
  • Draft comment:
    Consider making task_id in UpdateResponse optional to maintain consistency with IngestionResponse.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The task_id field in IngestionResponse is marked as Optional, but in the UpdateResponse class, it is not. This inconsistency might lead to confusion or errors if the task_id is sometimes not present. It would be better to make it consistent across similar response models.
2. py/tests/integration/harness_cli.py:177
  • Draft comment:
    Update the print statement to "Hybrid search test passed" to accurately reflect the test being performed.
  • Reason this comment was not posted:
    Confidence changes required: 20%
    The test_hybrid_search_sample_file_filter_cli function has a misleading print statement. It prints "Vector search test passed" even though it's testing hybrid search. This could confuse someone reading the test results.
3. py/tests/integration/harness_sdk.py:342
  • Draft comment:
    Avoid overwriting the response variable with a string. Use a different variable name for accumulating the response content.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_SJ0SXXgtdlGr1Mcv


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

},
)

response = ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid overwriting the response variable with a string. Use a different variable name for accumulating the response content.

@emrgnt-cmplxty emrgnt-cmplxty merged commit 3843e6e into main Oct 5, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant