Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump #1340

Merged
merged 1 commit into from
Oct 4, 2024
Merged

bump #1340

merged 1 commit into from
Oct 4, 2024

Conversation

emrgnt-cmplxty
Copy link
Contributor

@emrgnt-cmplxty emrgnt-cmplxty commented Oct 4, 2024

Important

Fix filter logic in retrieval_router.py and bump version to 3.2.5.

  • Bug Fix:
    • Corrected filter logic in _select_filters() in retrieval_router.py to use search_settings.filters instead of vector_search_settings.filters.
  • Version Update:
    • Bumped version from 3.2.4 to 3.2.5 in pyproject.toml.

This description was created by Ellipsis for f985f7f. It will automatically update as commits are pushed.

@emrgnt-cmplxty emrgnt-cmplxty marked this pull request as ready for review October 4, 2024 15:22
Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yc_demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 3:24pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
recommendation_platform ⬜️ Ignored (Inspect) Oct 4, 2024 3:24pm

@emrgnt-cmplxty emrgnt-cmplxty merged commit 187ba14 into main Oct 4, 2024
3 of 7 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to f985f7f in 8 seconds

More details
  • Looked at 39 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. py/core/main/api/retrieval_router.py:15
  • Draft comment:
    Reorder imports to follow PEP8 guidelines: standard library imports, third-party imports, and local imports, each sorted alphabetically.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The import order in retrieval_router.py is not following PEP8 guidelines. Imports should be grouped into standard library imports, related third-party imports, and local application/library-specific imports. Within these groups, imports should be sorted alphabetically.

Workflow ID: wflow_SynoTJ5Ktb8sKA0y


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant