Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch/fix ingestion #1339

Merged
merged 5 commits into from
Oct 4, 2024
Merged

Patch/fix ingestion #1339

merged 5 commits into from
Oct 4, 2024

Conversation

emrgnt-cmplxty
Copy link
Contributor

@emrgnt-cmplxty emrgnt-cmplxty commented Oct 4, 2024

Important

Enhanced ingestion and retrieval processes with updated API responses, improved error handling, and response streaming capabilities.

  • Ingestion:
    • Updated openapi.json to include ResultsWrapper_list_IngestionResponse__ for /v2/ingest_files and /v2/ingest_chunks responses.
    • Modified ingestion_workflow.py to handle ingestion_config directly without JSON serialization.
  • Retrieval:
    • Added WrappedCompletionResponse in responses.py for completion responses.
    • Improved error handling in retrieval_service.py for search and RAG operations.
    • Enhanced streaming response logic in retrieval_router.py for RAG and agent endpoints.
  • Misc:
    • Removed trailing whitespace in retrieval.py and retrieval_service.py.
    • Updated version to 3.2.4 in pyproject.toml.

This description was created by Ellipsis for 45736a9. It will automatically update as commits are pushed.

@emrgnt-cmplxty emrgnt-cmplxty marked this pull request as ready for review October 4, 2024 07:21
@emrgnt-cmplxty emrgnt-cmplxty merged commit 6e1c594 into main Oct 4, 2024
4 of 9 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 45736a9 in 41 seconds

More details
  • Looked at 172 lines of code in 8 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. py/core/main/orchestration/simple/ingestion_workflow.py:160
  • Draft comment:
    Ensure that the downstream code can handle ingestion_config as an object, as it is no longer serialized to JSON.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change in the ingestion_workflow.py file involves removing the JSON serialization of the ingestion_config before passing it to the ingest_input dictionary. This change is likely intended to simplify the handling of the ingestion_config by passing it directly as an object rather than a JSON string. This is a reasonable change if the downstream code can handle the ingestion_config as an object.

Workflow ID: wflow_l88bhYFNG0ntvJTG


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant