Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch/decruft openapi json #1338

Merged
merged 4 commits into from
Oct 4, 2024
Merged

Patch/decruft openapi json #1338

merged 4 commits into from
Oct 4, 2024

Conversation

emrgnt-cmplxty
Copy link
Contributor

@emrgnt-cmplxty emrgnt-cmplxty commented Oct 4, 2024

Important

Update OpenAPI response schemas for ingestion endpoints and improve code formatting in ingestion_router_openapi.yml.

  • OpenAPI Specification Updates:
    • Update response schema for /v2/ingest_files to ResultsWrapper_list_IngestionResponse__ in openapi.json.
    • Update response schema for /v2/update_files to ResultsWrapper_UpdateResponse_ in openapi.json.
    • Update response schema for /v2/ingest_chunks to ResultsWrapper_list_IngestionResponse__ in openapi.json.
  • Code Formatting:
    • Minor formatting improvements in ingestion_router_openapi.yml for better readability.

This description was created by Ellipsis for cca0c2c. It will automatically update as commits are pushed.

Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yc_demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 2:35am
yc-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2024 2:35am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
recommendation_platform ⬜️ Ignored (Inspect) Oct 4, 2024 2:35am

@emrgnt-cmplxty emrgnt-cmplxty merged commit df2ad6c into main Oct 4, 2024
4 of 9 checks passed
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to cca0c2c in 41 seconds

More details
  • Looked at 54 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. docs/api-reference/openapi.json:1
  • Draft comment:
    The response schema for the "/v2/ingest_files" endpoint has been updated to "ResultsWrapper_list_IngestionResponse__". Ensure that this schema is defined in the components section to avoid any reference errors.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR modifies the OpenAPI JSON file to update the response schema for the "/v2/ingest_files" endpoint. The response schema has been changed from a generic schema to a specific "ResultsWrapper_list_IngestionResponse__" schema. This change is consistent with the intent to provide more detailed response information.

Workflow ID: wflow_re3zJS3H884qStKY


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant