Corrections for KG SDK usage #1330
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to fa6000e in 25 seconds
More details
- Looked at
283lines of code in4files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. py/cli/commands/kg.py:109
- Draft comment:
Overwritingkg_enrichment_settingsunconditionally whenforce_kg_enrichmentis true may lead to loss of other settings. Consider updating the dictionary instead of overwriting it. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_JNmHC5M686NZ7Gu5
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| run_type = "run" | ||
| kg_creation_settings = {} | ||
|
|
||
| run_type = "run" if run else "estimate" | ||
|
|
||
| if force_kg_creation: | ||
| kg_creation_settings = {"force_kg_creation": True} |
There was a problem hiding this comment.
Overwriting kg_creation_settings unconditionally when force_kg_creation is true may lead to loss of other settings. Consider updating the dictionary instead of overwriting it.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 830fa66 in 13 seconds
More details
- Looked at
38lines of code in2files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_Axdq55B2P9OmCeHJ
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 0ad0827 in 17 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. py/cli/commands/kg.py:33
- Draft comment:
Thecreate_graphfunction should be asynchronous as per the PR description. Useasync def create_graphinstead ofdef create_graph. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable:
The comment is based on the PR description, which is not visible in the code. The change in the function signature from 'async def' to 'def' suggests an intentional change. Without strong evidence from the code itself, the comment seems speculative.
I might be missing the context of the PR description, which could provide a reason for the function to be asynchronous. However, the code change suggests a deliberate decision to make it synchronous.
The code change itself is the strongest evidence we have, and it suggests the function should be synchronous. Without seeing the PR description, we should not assume it overrides the code change.
Delete the comment as it is speculative and not based on strong evidence from the code itself.
Workflow ID: wflow_LuSYXpDMXFhAW4QF
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
* fix issues in compose (#1324) * Update Hatchet compose setup (#1327) * add ingest chunks workflows (#1329) * add ingest chunks workflows * finalize ingest chunks * fix * Allow for exclusion of postgres (#1328) * update type checks (#1331) * Limiting KG Creation Scheduling (#1332) * try * up * up * space * add it in ingestion * rm ingestion * up * bump pkg * add a global project config (#1333) * Corrections for KG SDK usage (#1330) * Corrections for KG SDK usage * Clean up * missed file * Adding a completions endpoint (#1326) * up * rm unnecessary import * add completion model * up * Update JS (#1335) --------- Co-authored-by: Nolan Tremelling <[email protected]> Co-authored-by: Shreyas Pimpalgaonkar <[email protected]>
Important
Improves KG SDK by making functions asynchronous, refining input handling, updating data types, and enhancing error handling.
create_graphandenrich_graphfunctions inkg.pyare now asynchronous.run_typeset toKGRunType.ESTIMATEif not provided inkg_router.py.kg_creation_settingsandkg_enrichment_settingsdefault to empty dicts if not provided inkg.pyandkg_router.py.KGRunTypechanged to inherit fromstrinkg.pyandabstractions/kg.py.collection_idandrun_typeinKGMethodsnow acceptUnion[UUID, str]andUnion[str, KGRunType]respectively.ValidationErrorimport inkg_router.pyfor potential future use.kg.pyandkg_router.py.kg_router.py.This description was created by
for 0ad0827. It will automatically update as commits are pushed.