Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Exclusion Flag for Postgres #1328

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

NolanTrem
Copy link
Collaborator

@NolanTrem NolanTrem commented Oct 3, 2024

Important

Add --exclude-postgres flag to Docker setup to optionally skip Postgres container creation.

  • Behavior:
    • Add --exclude-postgres flag to serve command in server.py to skip creating a Postgres container.
    • Modify run_docker_serve() in docker_utils.py to handle exclude_postgres flag.
    • Update check_set_docker_env_vars() in docker_utils.py to conditionally set Postgres environment variables.
  • Docker Compose:
    • Add profiles: [postgres] to Postgres service in compose.full.yaml and compose.yaml.
    • Modify Docker commands in build_docker_command() in docker_utils.py to include/exclude Postgres profile based on flag.

This description was created by Ellipsis for f9d5f41. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to f9d5f41 in 55 seconds

More details
  • Looked at 191 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 drafted comments based on config settings.
1. py/cli/utils/docker_utils.py:360
  • Draft comment:
    The logic for pull_command and up_command is reversed. When exclude_postgres is true, the --profile postgres should not be included. Please swap the logic for pull_command and up_command when exclude_postgres is true.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    The comment seems to be incorrect because the logic in the code aligns with the expected behavior: --profile postgres is included when exclude_postgres is false and excluded when true. The comment suggests swapping the logic, which would actually introduce a bug.
    I might be misunderstanding the intended behavior of the exclude_postgres flag. However, based on the code, the current implementation seems correct.
    The code clearly shows the intended behavior, and the comment's suggestion would lead to incorrect logic. The critique does not change the conclusion.
    The comment is incorrect because the current logic in the code is correct. The comment should be deleted.
2. py/cli/utils/docker_utils.py:357
  • Draft comment:
    The logic for pull_command and up_command is reversed. When exclude_postgres is true, the --profile postgres should not be included. Please swap the logic for pull_command and up_command when exclude_postgres is true.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_r3krL0xUgpfWgIYt


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@emrgnt-cmplxty emrgnt-cmplxty merged commit 4d3bb3a into dev-minor Oct 3, 2024
6 of 8 checks passed
emrgnt-cmplxty added a commit that referenced this pull request Oct 4, 2024
* fix issues in compose (#1324)

* Update Hatchet compose setup (#1327)

* add ingest chunks workflows (#1329)

* add ingest chunks workflows

* finalize ingest chunks

* fix

* Allow for exclusion of postgres (#1328)

* update type checks (#1331)

* Limiting KG Creation Scheduling  (#1332)

* try

* up

* up

* space

* add it in ingestion

* rm ingestion

* up

* bump pkg

* add a global project config (#1333)

* Corrections for KG SDK usage (#1330)

* Corrections for KG SDK usage

* Clean up

* missed file

* Adding a completions endpoint (#1326)

* up

* rm unnecessary import

* add completion model

* up

* Update JS (#1335)

---------

Co-authored-by: Nolan Tremelling <[email protected]>
Co-authored-by: Shreyas Pimpalgaonkar <[email protected]>
@NolanTrem NolanTrem deleted the Nolan/ExcludePostgres branch October 4, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants