Dev minor #1148
Merged
Dev minor #1148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* improve telemetry * finish telemetry tweaks
* improve telemetry * finish telemetry tweaks * up
* improve telemetry * finish telemetry tweaks * up * fallback to main
* add system diagram * rm multi * fix overview * cleanup and fix * fix syntax
* up * up * up * up
* cleanups * bump pkg
* rm unstructured tag, add auto build on dev and dev-minor * delete old Dockerfile * add retries
* adding test pypi * make unstructured docker file * add on-push effects for dev * tweak workflows
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
* adding test pypi * make unstructured docker file * add on-push effects for dev * tweak workflows
* add boto3 * explain feature add
* update prompt * test and fix. Add dockerfile.dev * up
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 2d460c9 in 48 seconds
More details
- Looked at
2389lines of code in30files - Skipped
8files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. py/core/providers/prompts/r2r_prompts.py:199
- Draft comment:
Consider documenting the choice ofuuid5withNAMESPACE_DNSfor generating prompt IDs. This ensures consistency but might need explanation for future maintainers. - Reason this comment was not posted:
Confidence changes required:50%
The use ofuuid5withNAMESPACE_DNSfor generating prompt IDs is a good choice for consistency, but it should be documented or explained why this specific method is chosen over others.
Workflow ID: wflow_WXZmloVtgp1LAu9G
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
👍 Looks good to me! Incremental review on 198f872 in 49 seconds
More details
- Looked at
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_E6S34t6w5ySgJhly
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
NolanTrem
reviewed
Sep 13, 2024
| @@ -185,6 +185,7 @@ async def parse( | |||
| **self.config.chunking_config.extra_fields, | |||
| ) | |||
|
|
|||
| iteration = 0 # if there are no chunks | |||
There was a problem hiding this comment.
Should we not be failing if a document has no chunks?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add Docker build workflow and enhance prompt management
Summary:
Add Docker build workflow, enhance prompt management, and update file types and configurations.
Key points:
build-docker.ymlfor Docker image build and publish ondevanddev-minorbranches; removebuild-main.ymland updatepublish-to-pypi.yml.DockerfileandDockerfile.devwithtesseract-ocrandlibreoffice; add Unstructured models initialization.created_atandupdated_attimestamps toPromptinr2r_prompts.py; update prompt loading logic.parsing_and_chunking.mdxanddocument.pyto includeBMP,EPUB,HEIC, etc.autoinr2r.toml; add line item reference reminder inrag_agent.yaml.Generated with ❤️ by ellipsis.dev