Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker down and add unstructured client #1004

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

NolanTrem
Copy link
Collaborator

@NolanTrem NolanTrem commented Aug 29, 2024

🚀 This description was created by Ellipsis for commit 824d5dc

Summary:

This pull request refines Docker setup, adds unstructured client support, and updates related tests and configurations.

Key points:

  • .github/workflows/py-ci-cd.yml: Added push event for main branch.
  • py/cli/utils/docker_utils.py: Removed docker compose pull command in bring_down_docker_compose. Updated check_set_docker_env_vars to include exclude_ollama parameter.
  • py/core/providers/parsing/r2r_parsing.py: Simplified parser override logic in _initialize_parsers.
  • py/core/providers/parsing/unstructured_parsing.py: Added UnstructuredClient for API usage. Improved error handling for missing environment variables.
  • py/pyproject.toml: Added unstructured-client dependency.
  • py/tests/cli/test_command_group.py: Updated test to reflect CLI parameter changes.
  • py/tests/cli/utils/test_docker_utils.py: Updated tests to reflect changes in Docker utility functions.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 824d5dc in 18 seconds

More details
  • Looked at 298 lines of code in 7 files
  • Skipped 1 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. py/tests/cli/test_command_group.py:13
  • Draft comment:
    Ensure that the change in expected CLI parameters from 0 to 1 is intentional and aligns with the intended functionality of the CLI.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The change in test_cli_group_no_options from assert len(cli.params) == 0 to assert len(cli.params) == 1 indicates a change in the expected behavior of the CLI. This should be verified to ensure it aligns with the intended functionality.
2. py/cli/utils/docker_utils.py:221
  • Draft comment:
    Verify that the addition of exclude_ollama to check_set_docker_env_vars and the corresponding logic changes align with the intended functionality.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The check_set_docker_env_vars function has been updated to include exclude_ollama as a parameter, and the logic has been adjusted accordingly. This change should be verified to ensure it aligns with the intended functionality.
3. py/core/providers/parsing/r2r_parsing.py:84
  • Draft comment:
    Ensure that the refactoring to yield DocumentExtraction directly aligns with the intended functionality and does not introduce any issues.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The parse method in r2r_parsing.py and unstructured_parsing.py has been refactored to yield DocumentExtraction directly instead of assigning it to a variable first. This change should be verified to ensure it aligns with the intended functionality.
4. py/core/providers/parsing/unstructured_parsing.py:117
  • Draft comment:
    Ensure that the refactoring to yield DocumentExtraction directly aligns with the intended functionality and does not introduce any issues.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The parse method in unstructured_parsing.py has been refactored to yield DocumentExtraction directly instead of assigning it to a variable first. This change should be verified to ensure it aligns with the intended functionality.

Workflow ID: wflow_7Og19qoTJavGQMP3


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@NolanTrem NolanTrem merged commit 66c44f2 into main Aug 29, 2024
4 checks passed
@NolanTrem NolanTrem deleted the Nolan/FixDockerDownAndAddUnstructuredClient branch August 29, 2024 22:11
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

see 154 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant