Fix arrange for multiple (>2 columns) for some cases
#68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This cleans up the sorting logic somewhat to make it a bit easier to follow, too. Mainly it fixes the sorting bug that caused: Vindaar/ggplotnim#180
(Devel as of today at least, wasn't working with a devel from a bit more than a week ago, which however still worked with the previous code, but that is still broken on Nim 2.0.4)
Vindaar
added a commit
to Vindaar/ggplotnim
that referenced
this pull request
Sep 5, 2024
The facet plot changed due to SciNim/Datamancer#68 Previously it was missing some data.
Vindaar
added a commit
to Vindaar/ggplotnim
that referenced
this pull request
Sep 5, 2024
The facet plot changed due to SciNim/Datamancer#68 Previously it was missing some data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old sorting logic was not only a bit hard to follow, but also had a bug that could trigger when sorting for more than 2 columns.
The new logic is still not great, but that is unfortunately owed to the fact that the runtime type info of the
Columndatatype makes it hard to clean up much more (outside of not relying onalgorithm/sortand writing a fully customsorting implementation that works directly on a DF).
This fixes ggplotnim issue:
Vindaar/ggplotnim#180