-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a dispatch to SimpleNewtonRaphson for NNLS and SimpleGaussNewton #91
Conversation
Codecov Report
@@ Coverage Diff @@
## main #91 +/- ##
==========================================
- Coverage 92.54% 92.47% -0.07%
==========================================
Files 21 21
Lines 1059 1063 +4
==========================================
+ Hits 980 983 +3
- Misses 79 80 +1
📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
LBroyden is having issues, @avik-pal can you look into that? https://github.com/SciML/SimpleNonlinearSolve.jl/actions/runs/6690175885/job/18174996133?pr=91#step:6:581 |
79adb60
to
3b587fb
Compare
I will take a look at LBroyden. |
This change is likely the reason for a CI issue in Manifolds.jl: https://github.com/JuliaManifolds/Manifolds.jl/actions/runs/6774649334/job/18412199878
|
@ChrisRackauckas this probably needed a version lower bound on SciMLBase |
Also https://github.com/JuliaManifolds/Manifolds.jl/actions/runs/6774649334/job/18412199878#step:9:86 is v"1.98", not even sure how such an old version got installed |
I forgot to update BoundaryValueDiffEq compatibility in docs; anyway, this also happens on Julia 1.6: https://github.com/JuliaManifolds/Manifolds.jl/actions/runs/6774649345/job/18412201063 where newer BoundaryValueDiffEq is not available. |
Fixes #82