Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a dispatch to SimpleNewtonRaphson for NNLS and SimpleGaussNewton #91

Merged
merged 4 commits into from
Nov 3, 2023

Conversation

ChrisRackauckas
Copy link
Member

Fixes #82

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

Merging #91 (cf03317) into main (0d73574) will decrease coverage by 0.07%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main      #91      +/-   ##
==========================================
- Coverage   92.54%   92.47%   -0.07%     
==========================================
  Files          21       21              
  Lines        1059     1063       +4     
==========================================
+ Hits          980      983       +3     
- Misses         79       80       +1     
Files Coverage Δ
src/SimpleNonlinearSolve.jl 76.47% <ø> (ø)
src/raphson.jl 88.63% <83.33%> (-1.37%) ⬇️

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@ChrisRackauckas
Copy link
Member Author

@avik-pal
Copy link
Member

avik-pal commented Nov 3, 2023

I will take a look at LBroyden.

test/least_squares.jl Outdated Show resolved Hide resolved
@ChrisRackauckas ChrisRackauckas merged commit ea20ad6 into main Nov 3, 2023
16 of 20 checks passed
@ChrisRackauckas ChrisRackauckas deleted the least_squares branch November 3, 2023 15:03
@mateuszbaran
Copy link

This change is likely the reason for a CI issue in Manifolds.jl: https://github.com/JuliaManifolds/Manifolds.jl/actions/runs/6774649334/job/18412199878

ERROR: LoadError: UndefVarError: `NonlinearLeastSquaresProblem` not defined
Stacktrace:
 [1] top-level scope
   @ ~/.julia/packages/SimpleNonlinearSolve/nusbP/src/raphson.jl:66
 [2] include(mod::Module, _path::String)
   @ Base ./Base.jl:457
 [3] include(x::String)
   @ SimpleNonlinearSolve ~/.julia/packages/SimpleNonlinearSolve/nusbP/src/SimpleNonlinearSolve.jl:1
 [4] top-level scope
   @ ~/.julia/packages/SimpleNonlinearSolve/nusbP/src/SimpleNonlinearSolve.jl:30
 [5] include
   @ ./Base.jl:457 [inlined]
 [6] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{String}, dl_load_path::Vector{String}, load_path::Vector{String}, concrete_deps::Vector{Pair{Base.PkgId, UInt128}}, source::String)
   @ Base ./loading.jl:2049
 [7] top-level scope
   @ stdin:3
in expression starting at /home/runner/.julia/packages/SimpleNonlinearSolve/nusbP/src/raphson.jl:66
in expression starting at /home/runner/.julia/packages/SimpleNonlinearSolve/nusbP/src/SimpleNonlinearSolve.jl:1
in expression starting at stdin:3
ERROR: LoadError: Failed to precompile SimpleNonlinearSolve [727e6d20-b764-4bd8-a329-72de5adea6c7] to "/home/runner/.julia/compiled/v1.9/SimpleNonlinearSolve/jl_TcxlTY".
Stacktrace:
  [1] error(s::String)
    @ Base ./error.jl:35
  [2] compilecache(pkg::Base.PkgId, path::String, internal_stderr::IO, internal_stdout::IO, keep_loaded_modules::Bool)
    @ Base ./loading.jl:2300
  [3] compilecache
    @ ./loading.jl:2167 [inlined]
  [4] _require(pkg::Base.PkgId, env::String)
    @ Base ./loading.jl:1805
  [5] _require_prelocked(uuidkey::Base.PkgId, env::String)
    @ Base ./loading.jl:1660
  [6] macro expansion
    @ ./loading.jl:1648 [inlined]
  [7] macro expansion
    @ ./lock.jl:267 [inlined]
  [8] require(into::Module, mod::Symbol)
    @ Base ./loading.jl:1611
  [9] include
    @ ./Base.jl:457 [inlined]
 [10] include_package_for_output(pkg::Base.PkgId, input::String, depot_path::Vector{String}, dl_load_path::Vector{String}, load_path::Vector{String}, concrete_deps::Vector{Pair{Base.PkgId, UInt128}}, source::String)
    @ Base ./loading.jl:2049
 [11] top-level scope
    @ stdin:3
in expression starting at /home/runner/.julia/packages/OrdinaryDiffEq/JJd6g/src/OrdinaryDiffEq.jl:1
in expression starting at stdin:3
ERROR: LoadError: Failed to precompile OrdinaryDiffEq [1dea7af3-3e70-54e6-95c3-0bf5283fa5ed] to "/home/runner/.julia/compiled/v1.9/OrdinaryDiffEq/jl_zdd1L8".
Stacktrace:
 [1] error(s::String)
   @ Base ./error.jl:35
 [2] compilecache(pkg::Base.PkgId, path::String, internal_stderr::IO, internal_stdout::IO, keep_loaded_modules::Bool)
   @ Base ./loading.jl:2300
 [3] compilecache
   @ ./loading.jl:2167 [inlined]
 [4] _require(pkg::Base.PkgId, env::String)
   @ Base ./loading.jl:1805
 [5] _require_prelocked(uuidkey::Base.PkgId, env::String)
   @ Base ./loading.jl:1660
 [6] macro expansion
   @ ./loading.jl:1648 [inlined]
 [7] macro expansion
   @ ./lock.jl:267 [inlined]
 [8] require(into::Module, mod::Symbol)
   @ Base ./loading.jl:1611
in expression starting at /home/runner/work/Manifolds.jl/Manifolds.jl/docs/make.jl:39

@avik-pal
Copy link
Member

avik-pal commented Nov 6, 2023

@ChrisRackauckas this probably needed a version lower bound on SciMLBase

@avik-pal
Copy link
Member

avik-pal commented Nov 6, 2023

Also https://github.com/JuliaManifolds/Manifolds.jl/actions/runs/6774649334/job/18412199878#step:9:86 is v"1.98", not even sure how such an old version got installed

@mateuszbaran
Copy link

I forgot to update BoundaryValueDiffEq compatibility in docs; anyway, this also happens on Julia 1.6: https://github.com/JuliaManifolds/Manifolds.jl/actions/runs/6774649345/job/18412201063 where newer BoundaryValueDiffEq is not available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add dispatch for NLS in SimpleNewtonRaphson
3 participants