Add compat entries and change default norm #105
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #105 +/- ##
==========================================
+ Coverage 91.54% 92.16% +0.61%
==========================================
Files 16 16
Lines 982 983 +1
==========================================
+ Hits 899 906 +7
+ Misses 83 77 -6 ☔ View full report in Codecov by Sentry. |
src/nlsolve/trustRegion.jl
Outdated
|
|
||
| # Update the trust region radius. | ||
| if r < η₂ | ||
| if Bool(r ≥ η₂) |
There was a problem hiding this comment.
Bool is a noop in the general case, but allows me to disambiguate a conditional operation vs a branch in BatchedArrays without messing around with the IR.
|
Let's wait on the merge and release of 1.0, there are a couple of correctness issues that show up in the 23 test cases. I will fix them together with the nonlinearsolve.jl PR |
|
@ChrisRackauckas this is good to go. Let's release this. For NonlinearSolve.jl we need to wait for the PR fixing the allocations. Once that is done, I will create a PR with updating the compat for SimpleNonlinearSolve and doing a couple of deprecations. |
No description provided.