Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port over improvements from NonlinearSolve #100

Merged
merged 24 commits into from
Nov 28, 2023

Conversation

avik-pal
Copy link
Member

@avik-pal avik-pal commented Nov 22, 2023

Copy link

codecov bot commented Nov 22, 2023

Codecov Report

Attention: 74 lines in your changes are missing coverage. Please review.

Comparison is base (5c569ae) 92.45% compared to head (594100e) 91.54%.

Files Patch % Lines
src/utils.jl 80.39% 40 Missing ⚠️
src/nlsolve/lbroyden.jl 86.76% 9 Missing ⚠️
src/bracketing/bisection.jl 86.53% 7 Missing ⚠️
src/bracketing/ridder.jl 91.30% 4 Missing ⚠️
src/bracketing/falsi.jl 91.42% 3 Missing ⚠️
src/bracketing/itp.jl 95.31% 3 Missing ⚠️
src/SimpleNonlinearSolve.jl 93.33% 2 Missing ⚠️
src/ad.jl 96.66% 1 Missing ⚠️
src/bracketing/alefeld.jl 50.00% 1 Missing ⚠️
src/bracketing/brent.jl 98.43% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
- Coverage   92.45%   91.54%   -0.92%     
==========================================
  Files          21       16       -5     
  Lines        1061      982      -79     
==========================================
- Hits          981      899      -82     
- Misses         80       83       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avik-pal avik-pal closed this Nov 28, 2023
@avik-pal avik-pal reopened this Nov 28, 2023
@avik-pal avik-pal marked this pull request as ready for review November 28, 2023 02:19
@avik-pal avik-pal closed this Nov 28, 2023
@avik-pal avik-pal reopened this Nov 28, 2023
@avik-pal
Copy link
Member Author

Good to go for me. The batched solvers which were dropped from here, are working perfectly in the private BatchedArrays repo, so we need to wait for sometime to get a tutorial on that.

@ChrisRackauckas ChrisRackauckas merged commit aeebc14 into SciML:main Nov 28, 2023
10 of 12 checks passed
@ChrisRackauckas
Copy link
Member

I'm calling this 1.0

@avik-pal avik-pal deleted the ap/cleanup branch November 28, 2023 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants