-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolved open issues #10
base: master
Are you sure you want to change the base?
Conversation
…r end date" This reverts commit ad54f42.
…f-00XXX00 Warning triggered if infinity_indicator found in SSIM start or end date
…coding-formats use determined encoding format for importing
- as some airlines deviate from SSIM standards, seat classes were left over and thereby not read by the algorithm. Instead, by focusing on provided information one is able to read all seat classes. - introduced acv_splitter to make distinction relevant acv info and aircraft version reference code
…seat-order focus on provided instead of expected aircraft_configuration_string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great Timo! I've added some comments off the top of my head.
I would recommend you add an example test case of the problem you're fixing for here. See an example case here: https://github.com/Schiphol-Hub/ssim/blob/master/test/data/slots_netherlands.yml. pytest
tests can then be used to make sure this change did indeed solve the problem and did not violate another expectation we have for the parser.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @timonoortman-aas. Could you check the failing build what is going on there?
- main adjustment is that encoding format could be provided as keyword argument (instead of inferring encoding format in code)
@FlorisHoogenboom Could you please review it again? |
Can I help push this along somehow? |
The three open issues have been resolved in this pull request: