Refactored some code and added module name information to Call classes #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LocalCall uses 'kwarg' parameter while RunnerCall and WheelCall use 'kwargs'(with s ), during last PR i renamed 'kwarg' parameter to 'kwargs' parameter and extracted that parameter in a parent class which was wrong and caused some issues. I have reverted those changes back. Code can definitely be improved further but my lack of Salt knowledge and right now being on holidays is kind of hindrance for the time being.
Related discussion can be seen in #193 . Main goal of this PR was issue #149.