Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entity Bulk Add (copy Attributes) (#196) #201

Merged
merged 17 commits into from
Apr 23, 2024

Conversation

TeodoraPavlova
Copy link
Contributor

resolves #196

… race condition and result of duplications, replace activated with mounted, so references can load again after save
frontend/src/components/EntityBulkAdd.vue Outdated Show resolved Hide resolved
frontend/src/components/inputs/EntityForm.vue Outdated Show resolved Hide resolved
frontend/src/components/Entity.vue Outdated Show resolved Hide resolved
frontend/src/components/EntityBulkAdd.vue Outdated Show resolved Hide resolved
frontend/src/components/EntityBulkAdd.vue Outdated Show resolved Hide resolved
frontend/src/components/EntityBulkAdd.vue Outdated Show resolved Hide resolved
frontend/src/components/EntityBulkAdd.vue Show resolved Hide resolved
frontend/src/components/EntityBulkAdd.vue Outdated Show resolved Hide resolved
frontend/src/components/EntityBulkAdd.vue Outdated Show resolved Hide resolved
@TeodoraPavlova TeodoraPavlova changed the title Entity Bulk Add (copy Attributes) Entity Bulk Add (copy Attributes) (https://github.com/SUSE/aimaas/issues/196) Apr 8, 2024
@TeodoraPavlova TeodoraPavlova changed the title Entity Bulk Add (copy Attributes) (https://github.com/SUSE/aimaas/issues/196) Entity Bulk Add (copy Attributes) (#196) Apr 8, 2024
@crazyscientist crazyscientist self-assigned this Apr 16, 2024
frontend/src/components/Entity.vue Show resolved Hide resolved
frontend/src/components/EntityBulkAdd.vue Outdated Show resolved Hide resolved
frontend/src/components/EntityBulkAdd.vue Outdated Show resolved Hide resolved
frontend/src/components/EntityBulkAdd.vue Outdated Show resolved Hide resolved
frontend/src/components/EntityBulkAdd.vue Show resolved Hide resolved
frontend/src/components/inputs/EntityForm.vue Outdated Show resolved Hide resolved
frontend/src/components/EntityBulkAdd.vue Show resolved Hide resolved
@jonas-brr
Copy link
Contributor

@TeodoraPavlova @crazyscientist I hate imposing yet another thing, but would you be against using prettier to format the source code? I wouldn't be against if someone'd like to tweak the default settings, but if not we could all just enable the prettier plugin to reformat on save and call it a day (?) 🤔

@crazyscientist
Copy link
Collaborator

would you be against using prettier to format the source code?

@jonas-brr Not at all. So far, PyCharm (without plugin) seemed to do a well enough job for me. Would you like to report this as a new issue?

@jonas-brr
Copy link
Contributor

PyCharm (without plugin) seemed to do a well enough job for me

@crazyscientist after trying it out ( control + alt + L (?) ), pyCharm doesn't seem to be clever enough to understand .vue (without the vuejs plugin - not available in community edition). However even with pure html/js files, it looks like it doesn't a good job there either.

I'd say prettier would be a good thing for having consistent formatting (though I might be the only one bothered by that 😄 ).

Yes, if you (and others probably) aren't using VS code, I could create a tiny issue for adding prettier to npm scripts for starters, and maybe adding a pipeline check(s) later (?)

@crazyscientist
Copy link
Collaborator

I could create a tiny issue for adding prettier to npm scripts for starters, and maybe adding a pipeline check(s) later (?)

@jonas-brr That sounds like a very good plan 👍

@TeodoraPavlova
Copy link
Contributor Author

@jonas-brr As you suggested, I'm not bothered by that and PyCharm does the job for me. However, there could be annoying consequences of formatters like messing up the git history (everything looks like it's done by 1 person or at least the last changes and you have to dig). The other thing is merge conflicts..

But I'm not against formatters, I just have bad memories 😆 If this is important for you, please go ahead, I think in this case the things I've suffered from before are not relevant (not a lot of pending MRs and the git history does not matter, especially if we're planning to migrate to composition API)

@TeodoraPavlova
Copy link
Contributor Author

@crazyscientist @jonas-brr is still anything expected from me here?

frontend/src/components/Entity.vue Outdated Show resolved Hide resolved
frontend/src/components/EntityBulkAdd.vue Outdated Show resolved Hide resolved
frontend/src/components/inputs/EntityForm.vue Outdated Show resolved Hide resolved
Copy link
Collaborator

@crazyscientist crazyscientist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazyscientist crazyscientist merged commit df11fa3 into master Apr 23, 2024
4 checks passed
@crazyscientist crazyscientist deleted the add-entity-copy-attributes branch April 23, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bulk Add products
3 participants