Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIMAAS #197: refactor users/groups state management #198

Merged
merged 2 commits into from
Apr 11, 2024
Merged

AIMAAS #197: refactor users/groups state management #198

merged 2 commits into from
Apr 11, 2024

Conversation

jonas-brr
Copy link
Contributor

@jonas-brr jonas-brr commented Mar 27, 2024 •
edited by crazyscientist
Loading

  • remove the provide/inject in favor of a centralized store-like solution
  • remove the unnecessary/broken keep-alive in tabbing component
  • add Suspense to tabbing component for a common loading behavior
  • small layout/responsiveness tweak for the user/group manager components: col -> flex
  • various smaller fixes across the app (broken reactivity, console warnings, ...)

closes #197

@jonas-brr jonas-brr changed the title AIMAAS #25: refactor users/groups state management AIMAAS #197: refactor users/groups state management Mar 27, 2024
@jonas-brr jonas-brr force-pushed the bugfix-25-users-and-groups-state-mgmt branch from 3886359 to 28a588d Compare March 27, 2024 09:10
@crazyscientist crazyscientist self-assigned this Mar 28, 2024
crazyscientist
crazyscientist requested changes Mar 28, 2024
View reviewed changes
frontend/src/store/auth.js Outdated Show resolved Hide resolved
frontend/src/store/auth.js Outdated Show resolved Hide resolved
frontend/src/composables/api.js Outdated Show resolved Hide resolved
frontend/src/components/Entity.vue Show resolved Hide resolved
frontend/src/components/layout/Tabbing.vue Outdated Show resolved Hide resolved
frontend/src/components/auth/GroupManager.vue Outdated Show resolved Hide resolved
frontend/src/components/auth/GroupManager.vue Outdated Show resolved Hide resolved
frontend/src/components/auth/GroupMembers.vue Show resolved Hide resolved
frontend/src/components/auth/PermissionList.vue Show resolved Hide resolved
frontend/src/components/auth/PermissionList.vue Show resolved Hide resolved
@SUSE SUSE deleted a comment from jonas-brr Apr 11, 2024
@crazyscientist crazyscientist merged commit 098e161 into master Apr 11, 2024
4 checks passed
@crazyscientist crazyscientist deleted the bugfix-25-users-and-groups-state-mgmt branch April 11, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazyscientist crazyscientist crazyscientist approved these changes

Assignees

@crazyscientist crazyscientist

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

List of users and groups is not loaded
2 participants
@jonas-brr @crazyscientist