refactor ReferencedEntitySelect: remove selected watcher because of a…

… race condition and result of duplications, replace activated with mounted, so references can load again after save
SUSE · Apr 4, 2024 · 45d2dbd · 45d2dbd
1 parent 3620404
commit 45d2dbd
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/frontend/src/components/Entity.vue b/frontend/src/components/Entity.vue
@@ -45,7 +45,7 @@ export default {
         },
         {
           name: "Bulk Add (copy Attributes)",
-          component: shallowRef(EntityBulkAdd),
+          component: EntityBulkAdd,
           icon: "add_circle",
           tooltip: "Copy over entity attributes to a new entities"
         },

diff --git a/frontend/src/components/EntityBulkAdd.vue b/frontend/src/components/EntityBulkAdd.vue
@@ -34,15 +34,15 @@ export default {
   },
   computed: {
     entityFormComponentsCountRange() {
-      return [...Array(this.entityFormComponentCount).keys()]
+      return [...Array(this.entityFormComponentCount).keys()];
     },
   },
   methods: {
     async saveAll() {
       const promises = Object.entries(this.$refs)
           .filter(x => x[0].startsWith("entity-form-"))
           .map(x => x[1][0].createEntity());
-      await Promise.all(promises)
+      await Promise.all(promises);
     },
     addEntityForm() {
       ++this.entityFormComponentCount;

diff --git a/frontend/src/components/inputs/ReferencedEntitySelect.vue b/frontend/src/components/inputs/ReferencedEntitySelect.vue
@@ -61,7 +61,7 @@ export default {
       currentEntitySlug: this.$route.params.entitySlug,
     }
   },
-  activated() {
+  mounted() {
     this.getSelected();
   },
   computed: {
@@ -134,10 +134,6 @@ export default {
     modelValue() {
       this.getSelected();
     },
-    selected: {
-      handler: "getSelected",
-      immediate: true
-    }
   }
 };
 </script>