Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ruby image README #1238

Merged
merged 1 commit into from
Jun 12, 2024
Merged

Add Ruby image README #1238

merged 1 commit into from
Jun 12, 2024

Conversation

alexandrevicenzi
Copy link
Member

This is related to #993.

dcermak pushed a commit that referenced this pull request Jun 6, 2024
dcermak pushed a commit that referenced this pull request Jun 6, 2024
dcermak pushed a commit that referenced this pull request Jun 6, 2024
Copy link

github-actions bot commented Jun 6, 2024

Created a staging project on OBS for 6: home:defolos:BCI:Staging:SLE-15-SP6:6-1238
Changes pushed to branch 6-1238 as commit d410f0537aa6575e01413792202d1e792c5f19d1
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-1238 for x86_64: current state: published
Build results:

package name status build log
ruby-2.5-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-1238 for aarch64: current state: published
Build results:

package name status build log
ruby-2.5-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-1238 for s390x: current state: published
Build results:

package name status build log
ruby-2.5-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-1238 for ppc64le: current state: published
Build results:

package name status build log
ruby-2.5-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-1238 for x86_64: current state: published
Build results:

package name status build log
ruby-2.5-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-1238 for aarch64: current state: published
Build results:

package name status build log
ruby-2.5-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-1238 for s390x: current state: published
Build results:

package name status build log
ruby-2.5-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-1238 for ppc64le: current state: published
Build results:

package name status build log
ruby-2.5-image ✅ succeeded live log

Build succeeded ✅

To run BCI-tests against this PR, use the following command:

OS_VERSION=15.6 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-1238/ tox -- -n auto
The following images can be pulled from the staging project:
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-1238/containerfile/bci/ruby
⚠️⚠️ Project and Branch have been deleted ⚠️⚠️

Copy link

github-actions bot commented Jun 6, 2024

Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1238
Changes pushed to branch Tumbleweed-1238 as commit 69bcdd05cb5d8c6ec5e01ccc098209a9d5b7ca56
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1238 for x86_64: current state: published
Build results:

package name status build log
ruby-3.3-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1238 for aarch64: current state: published
Build results:

package name status build log
ruby-3.3-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1238 for x86_64: current state: published
Build results:

package name status build log
ruby-3.3-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1238 for aarch64: current state: published
Build results:

package name status build log
ruby-3.3-image ✅ succeeded live log

Build succeeded ✅

To run BCI-tests against this PR, use the following command:

OS_VERSION=tumbleweed TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-1238/ tox -- -n auto
The following images can be pulled from the staging project:
  • registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-1238/containerfile/opensuse/bci/ruby
⚠️⚠️ Project and Branch have been deleted ⚠️⚠️

Copy link

github-actions bot commented Jun 6, 2024

Created a staging project on OBS for 5: home:defolos:BCI:Staging:SLE-15-SP5:5-1238
Changes pushed to branch 5-1238 as commit 0f725279175ee051f1f1a1c4cfec1650183805a7
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:SLE-15-SP5:5-1238 for x86_64: current state: published
Build results:

package name status build log
ruby-2.5-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP5:5-1238 for aarch64: current state: published
Build results:

package name status build log
ruby-2.5-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP5:5-1238 for s390x: current state: published
Build results:

package name status build log
ruby-2.5-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP5:5-1238 for ppc64le: current state: published
Build results:

package name status build log
ruby-2.5-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP5:5-1238 for x86_64: current state: published
Build results:

package name status build log
ruby-2.5-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP5:5-1238 for aarch64: current state: published
Build results:

package name status build log
ruby-2.5-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP5:5-1238 for s390x: current state: published
Build results:

package name status build log
ruby-2.5-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP5:5-1238 for ppc64le: current state: published
Build results:

package name status build log
ruby-2.5-image ✅ succeeded live log

Build succeeded ✅

To run BCI-tests against this PR, use the following command:

OS_VERSION=15.5 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp5/5-1238/ tox -- -n auto
The following images can be pulled from the staging project:
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp5/5-1238/containerfile/bci/ruby
⚠️⚠️ Project and Branch have been deleted ⚠️⚠️

@alexandrevicenzi alexandrevicenzi mentioned this pull request Jun 6, 2024
17 tasks
src/bci_build/package/ruby/README.md.j2 Outdated Show resolved Hide resolved
src/bci_build/package/ruby/README.md.j2 Outdated Show resolved Hide resolved
CMD [ "ruby", "./main-script.rb" ]
```

Build and run the container image:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Build and run the container image:
Build and run a container image:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not building "a" container. I'm building "the" container from the above example. I feel that it is correct this way unless I'm missing something else here.

src/bci_build/package/ruby/README.md.j2 Outdated Show resolved Hide resolved
$ podman run --rm -v "$PWD":/app:Z -w /app {{ image.pretty_reference }} bundle install
```

To run a single script inside a container, use the following command:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To run a single script inside a container, use the following command:
To run a single script inside a container, use the command below:

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sentence is the same as other container images, any reason to change it?


## Encoding

The Ruby image explicitly sets the locale environment variable `LANG` to `C.UTF-8`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The Ruby image explicitly sets the locale environment variable `LANG` to `C.UTF-8`.
The Ruby image explicitly sets the locale environment variable `LANG` to `C.UTF-8`.

What does explicitly mean here? Can it be dropped?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is needed. The idea is that the Ruby image sets the LANG variable, possibly "explicitly sets" is redundant in this case.

If LANG is not set, Ruby might assume another locale, so we explicitly set a locale.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the default is C, so non-utf8 mode. this statement enforces UTF8 mode.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the word "explicitly", I don't think it is necessary.

dcermak pushed a commit that referenced this pull request Jun 11, 2024
dcermak pushed a commit that referenced this pull request Jun 11, 2024
Copy link

github-actions bot commented Jun 11, 2024

Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1238
Changes pushed to branch Tumbleweed-1238 as commit 24e89bc18783ec6e5a344741597fda7278042b01
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1238 for x86_64: current state: published
Build results:

package name status build log
ruby-3.3-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1238 for aarch64: current state: published
Build results:

package name status build log
ruby-3.3-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1238 for x86_64: current state: published
Build results:

package name status build log
ruby-3.3-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1238 for aarch64: current state: published
Build results:

package name status build log
ruby-3.3-image ✅ succeeded live log

Build succeeded ✅

To run BCI-tests against this PR, use the following command:

OS_VERSION=tumbleweed TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-1238/ tox -- -n auto
The following images can be pulled from the staging project:
  • registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-1238/containerfile/opensuse/bci/ruby

Copy link

github-actions bot commented Jun 11, 2024

Created a staging project on OBS for 6: home:defolos:BCI:Staging:SLE-15-SP6:6-1238
Changes pushed to branch 6-1238 as commit e9e17c9a84a1098439e5e6355ca3c84cc4aaa245
Build succeeded ✅

Build Results

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-1238 for x86_64: current state: published
Build results:

package name status build log
ruby-2.5-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-1238 for aarch64: current state: published
Build results:

package name status build log
ruby-2.5-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-1238 for s390x: current state: published
Build results:

package name status build log
ruby-2.5-image ⛔ excluded live log

Repository images in home:defolos:BCI:Staging:SLE-15-SP6:6-1238 for ppc64le: current state: published
Build results:

package name status build log
ruby-2.5-image ⛔ excluded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-1238 for x86_64: current state: published
Build results:

package name status build log
ruby-2.5-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-1238 for aarch64: current state: published
Build results:

package name status build log
ruby-2.5-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-1238 for s390x: current state: published
Build results:

package name status build log
ruby-2.5-image ✅ succeeded live log

Repository containerfile in home:defolos:BCI:Staging:SLE-15-SP6:6-1238 for ppc64le: current state: published
Build results:

package name status build log
ruby-2.5-image ✅ succeeded live log

Build succeeded ✅

To run BCI-tests against this PR, use the following command:

OS_VERSION=15.6 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-1238/ tox -- -n auto
The following images can be pulled from the staging project:
  • registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-1238/containerfile/bci/ruby

dcermak pushed a commit that referenced this pull request Jun 11, 2024
Copy link

Created a staging project on OBS for 5: home:defolos:BCI:Staging:SLE-15-SP5:5-1238
Changes pushed to branch 5-1238 as commit 1a3673eca097fa97f25b781a0ffb48fac98f2809

@dirkmueller dirkmueller merged commit 2c9b6c2 into main Jun 12, 2024
7 of 8 checks passed
@dirkmueller dirkmueller deleted the ruby-readme branch June 12, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants