-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ruby image README #1238
Add Ruby image README #1238
Conversation
Created a staging project on OBS for 6: home:defolos:BCI:Staging:SLE-15-SP6:6-1238 Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ To run BCI-tests against this PR, use the following command: OS_VERSION=15.6 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-1238/ tox -- -n auto The following images can be pulled from the staging project:
|
Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1238 Build ResultsRepository
Repository
Repository
Repository
Build succeeded ✅ To run BCI-tests against this PR, use the following command: OS_VERSION=tumbleweed TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-1238/ tox -- -n auto The following images can be pulled from the staging project:
|
Created a staging project on OBS for 5: home:defolos:BCI:Staging:SLE-15-SP5:5-1238 Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ To run BCI-tests against this PR, use the following command: OS_VERSION=15.5 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp5/5-1238/ tox -- -n auto The following images can be pulled from the staging project:
|
CMD [ "ruby", "./main-script.rb" ] | ||
``` | ||
|
||
Build and run the container image: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build and run the container image: | |
Build and run a container image: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not building "a" container. I'm building "the" container from the above example. I feel that it is correct this way unless I'm missing something else here.
$ podman run --rm -v "$PWD":/app:Z -w /app {{ image.pretty_reference }} bundle install | ||
``` | ||
|
||
To run a single script inside a container, use the following command: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To run a single script inside a container, use the following command: | |
To run a single script inside a container, use the command below: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence is the same as other container images, any reason to change it?
|
||
## Encoding | ||
|
||
The Ruby image explicitly sets the locale environment variable `LANG` to `C.UTF-8`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Ruby image explicitly sets the locale environment variable `LANG` to `C.UTF-8`. | |
The Ruby image explicitly sets the locale environment variable `LANG` to `C.UTF-8`. |
What does explicitly mean here? Can it be dropped?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is needed. The idea is that the Ruby image sets the LANG
variable, possibly "explicitly sets" is redundant in this case.
If LANG
is not set, Ruby might assume another locale, so we explicitly set a locale.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the default is C
, so non-utf8 mode. this statement enforces UTF8 mode.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the word "explicitly", I don't think it is necessary.
ab27bf2
to
1f0ed6c
Compare
Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1238 Build ResultsRepository
Repository
Repository
Repository
Build succeeded ✅ To run BCI-tests against this PR, use the following command: OS_VERSION=tumbleweed TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-1238/ tox -- -n auto The following images can be pulled from the staging project:
|
Created a staging project on OBS for 6: home:defolos:BCI:Staging:SLE-15-SP6:6-1238 Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ To run BCI-tests against this PR, use the following command: OS_VERSION=15.6 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-1238/ tox -- -n auto The following images can be pulled from the staging project:
|
Created a staging project on OBS for 5: home:defolos:BCI:Staging:SLE-15-SP5:5-1238 |
This is related to #993.