-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python image README #1195
Add Python image README #1195
Conversation
Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1195 Build ResultsRepository
Repository
Repository
Repository
Build succeeded ✅ To run BCI-tests against this PR, use the following command: OS_VERSION=tumbleweed TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-1195/ tox -- -n auto The following images can be pulled from the staging project:
|
Created a staging project on OBS for 5: home:defolos:BCI:Staging:SLE-15-SP5:5-1195 Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ To run BCI-tests against this PR, use the following command: OS_VERSION=15.5 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp5/5-1195/ tox -- -n auto The following images can be pulled from the staging project:
|
Created a staging project on OBS for 6: home:defolos:BCI:Staging:SLE-15-SP6:6-1195 Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ To run BCI-tests against this PR, use the following command: OS_VERSION=15.6 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-1195/ tox -- -n auto The following images can be pulled from the staging project:
|
9b77e09
to
9070ca7
Compare
Created a staging project on OBS for 5: home:defolos:BCI:Staging:SLE-15-SP5:5-1195 Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ To run BCI-tests against this PR, use the following command: OS_VERSION=15.5 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp5/5-1195/ tox -- -n auto The following images can be pulled from the staging project:
|
Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1195 Build ResultsRepository
Repository
Repository
Repository
Build succeeded ✅ To run BCI-tests against this PR, use the following command: OS_VERSION=tumbleweed TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-1195/ tox -- -n auto The following images can be pulled from the staging project:
|
Created a staging project on OBS for 6: home:defolos:BCI:Staging:SLE-15-SP6:6-1195 Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ To run BCI-tests against this PR, use the following command: OS_VERSION=15.6 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-1195/ tox -- -n auto The following images can be pulled from the staging project:
|
9070ca7
to
8529386
Compare
Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1195 Build ResultsRepository
Repository
Repository
Repository
Build succeeded ✅ To run BCI-tests against this PR, use the following command: OS_VERSION=tumbleweed TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-1195/ tox -- -n auto The following images can be pulled from the staging project:
|
Created a staging project on OBS for 6: home:defolos:BCI:Staging:SLE-15-SP6:6-1195 Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ To run BCI-tests against this PR, use the following command: OS_VERSION=15.6 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-1195/ tox -- -n auto The following images can be pulled from the staging project:
|
Created a staging project on OBS for 5: home:defolos:BCI:Staging:SLE-15-SP5:5-1195 Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ To run BCI-tests against this PR, use the following command: OS_VERSION=15.5 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp5/5-1195/ tox -- -n auto The following images can be pulled from the staging project:
|
Created a staging project on OBS for 6: home:defolos:BCI:Staging:SLE-15-SP6:6-1195 Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ To run BCI-tests against this PR, use the following command: OS_VERSION=15.6 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-1195/ tox -- -n auto The following images can be pulled from the staging project:
|
Created a staging project on OBS for 5: home:defolos:BCI:Staging:SLE-15-SP5:5-1195 Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ To run BCI-tests against this PR, use the following command: OS_VERSION=15.5 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp5/5-1195/ tox -- -n auto The following images can be pulled from the staging project:
|
Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1195 Build ResultsRepository
Repository
Repository
Repository
Build succeeded ✅ To run BCI-tests against this PR, use the following command: OS_VERSION=tumbleweed TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-1195/ tox -- -n auto The following images can be pulled from the staging project:
|
9935d25
to
ec9a3b2
Compare
Created a staging project on OBS for 5: home:defolos:BCI:Staging:SLE-15-SP5:5-1195 Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ To run BCI-tests against this PR, use the following command: OS_VERSION=15.5 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp5/5-1195/ tox -- -n auto The following images can be pulled from the staging project:
|
Created a staging project on OBS for 6: home:defolos:BCI:Staging:SLE-15-SP6:6-1195 Build ResultsRepository
Repository
Repository
Repository
Repository
Repository
Repository
Repository
Build succeeded ✅ To run BCI-tests against this PR, use the following command: OS_VERSION=15.6 TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/sle-15-sp6/6-1195/ tox -- -n auto The following images can be pulled from the staging project:
|
Created a staging project on OBS for Tumbleweed: home:defolos:BCI:Staging:Tumbleweed:Tumbleweed-1195 Build ResultsRepository
Repository
Repository
Repository
Build succeeded ✅ To run BCI-tests against this PR, use the following command: OS_VERSION=tumbleweed TARGET=custom BASEURL=registry.opensuse.org/home/defolos/bci/staging/tumbleweed/tumbleweed-1195/ tox -- -n auto The following images can be pulled from the staging project:
|
- python{{ version }}-devel | ||
- python{{ version }}-pip | ||
{% if image.has_pipx -%} | ||
- python{{ version }}-pipx | ||
{% endif -%} | ||
{% if image.has_wheel -%} | ||
- python{{ version }}-wheel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is unfortunately incorrect for the system python on SLES 15. For python 3.6, the package is called python3-devel
not python36-devel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it worth listing the python3-devel
package here? otherwise I need to add a check if is_python_system
because it will be python3-devel
for the system version, not for 3.11 on SLE.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not worth listing python3-devel
imho, but the package names are incorrect for pip & wheel too. It's python3-pip
for python 3.6 and not python36-pip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reworked this section, no version number in names anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, the package version is incorrect :-(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
|
||
## Additional tools | ||
|
||
The following tools are included in the image: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe this shouldn't say "following tools" and then a list of package names. I think we could simply have two paragraphs that explain what "pip" is (if pip is available, which is always the case) and what pipx is (if pipx is available in the image).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of package name, I was considering having the tool name (e.g not python3-pipx, just pipx) and adding a small description.
- pipx — Install and Run Python Applications in Isolated Environments
@dirkmueller @dcermak WDYT? this at least fix the problem with including the package version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one thing we discussed is the usefulness of this section, because of this section this PR is stuck. Perhaps removing this completely or replacing it with a # pipx and # else section is better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can just mention that pip (& pipx) is/are installed, or just drop this section it entirely
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept this section, but I changed it to include tool names, it seems more useful.
ec9a3b2
to
d0781c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for your patience!
This is related to #993.