Skip to content

Commit

Permalink
drivers/video/isx019: Fix default_value of 3A status
Browse files Browse the repository at this point in the history
Fix default_value of ioctl(VIDIOC_QUERYCTRL)(id=V4L2_CID_3A_STATUS)
to AE operating and AWB operating, because both AE and AWB are
automatical adjustment mode by default.
  • Loading branch information
SPRESENSE committed Mar 26, 2024
1 parent d808ed4 commit 5f87192
Showing 1 changed file with 4 additions and 8 deletions.
12 changes: 4 additions & 8 deletions drivers/video/isx019.c
Original file line number Diff line number Diff line change
Expand Up @@ -196,15 +196,12 @@ struct isx019_default_value_s
int32_t vflip_still;
int32_t sharpness;
int32_t ae;
int32_t exptime;
int32_t wbmode;
int32_t hdr;
int32_t iso;
int32_t iso_auto;
int32_t meter;
int32_t spot_pos;
int32_t threealock;
int32_t threeastatus;
int32_t jpgquality;
};

Expand Down Expand Up @@ -1355,15 +1352,12 @@ static void store_default_value(FAR isx019_dev_t *priv)
def->vflip_still = get_value32(priv, IMGSENSOR_ID_VFLIP_STILL);
def->sharpness = get_value32(priv, IMGSENSOR_ID_SHARPNESS);
def->ae = get_value32(priv, IMGSENSOR_ID_EXPOSURE_AUTO);
def->exptime = get_value32(priv, IMGSENSOR_ID_EXPOSURE_ABSOLUTE);
def->wbmode = get_value32(priv, IMGSENSOR_ID_AUTO_N_PRESET_WB);
def->hdr = get_value32(priv, IMGSENSOR_ID_WIDE_DYNAMIC_RANGE);
def->iso = get_value32(priv, IMGSENSOR_ID_ISO_SENSITIVITY);
def->iso_auto = get_value32(priv, IMGSENSOR_ID_ISO_SENSITIVITY_AUTO);
def->meter = get_value32(priv, IMGSENSOR_ID_EXPOSURE_METERING);
def->spot_pos = get_value32(priv, IMGSENSOR_ID_SPOT_POSITION);
def->threealock = get_value32(priv, IMGSENSOR_ID_3A_LOCK);
def->threeastatus = get_value32(priv, IMGSENSOR_ID_3A_STATUS);
def->jpgquality = get_value32(priv, IMGSENSOR_ID_JPEG_QUALITY);
}

Expand Down Expand Up @@ -2045,8 +2039,10 @@ static int isx019_get_supported_value(FAR struct imgsensor_s *sensor,

case IMGSENSOR_ID_3A_STATUS:
val->type = IMGSENSOR_CTRL_TYPE_INTEGER;
SET_RANGE(val->u.range, MIN_3ASTATUS, MAX_3ASTATUS,
STEP_3ASTATUS, def->threeastatus);
SET_RANGE(val->u.range, MIN_3ASTATUS,
MAX_3ASTATUS, STEP_3ASTATUS,
IMGSENSOR_3A_STATUS_AE_OPERATING
| IMGSENSOR_3A_STATUS_AWB_OPERATING);
break;

case IMGSENSOR_ID_JPEG_QUALITY:
Expand Down

0 comments on commit 5f87192

Please sign in to comment.