Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SMS Spam project link in MLQuality #4

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

philippedeb
Copy link
Contributor

Issue

The link referring to the SMS Spam project in the following places is not working properly:

image

image

It results in https://se.ewi.tudelft.nl/material/projects/sms-spam/, a 404:

image

Solution

Changed the link to include the /remla prefix, which leads to the right place: https://se.ewi.tudelft.nl/remla/material/projects/sms-spam/.

Copy link
Collaborator

@proksch proksch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "correct" fix is to use a, for example, {%link material/projects/sms-spam.md%}. When doing so, Jekyll will complain, when the link is changed/removed.

@philippedeb philippedeb requested a review from proksch July 16, 2023 09:47
@philippedeb
Copy link
Contributor Author

Broken links in Markdown have been updated to {% link ... %} instead of the previous Liquid code {{ ... | absolute_path }}. Should route to the correct material now and also check whether the links exist before building/serving the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants