Added COOKIE_EXPIRATION environment variable
#4801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelstudios
added
the
Enhancement
axelstudios
changed the title
COOKIE_EXPIRATION environment variable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any background context you want to provide?
We were using
SESSION_EXPIRE_AT_BROWSER_CLOSE, which in "normal" cases causes the user to be logged out every time they close their browser. However, in modern browser environments with Chrome and Firefox most users have their browsers set to resume their session upon reopening, which causes sessions to be valid until the CSRF cookie expires (1 year).What's this PR do?
Adds support for a
COOKIE_EXPIRATIONenvironment variable that limits cookie validity to the Django default of two weeks, unless overriddenHow should this be manually tested?
Application/Cookiessection of the browser's developer tools, and ensure that the expiration is two weeks from now instead ofSessionWhat are the relevant tickets?
#4800