Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(styles): update Shell Bar to latest design [ci visual] #5675

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

InnaAtanasova
Copy link
Contributor

@InnaAtanasova InnaAtanasova commented Oct 2, 2024

Related Issue

Closes #5673

Description

update Shell Bar to latest design

BREAKING CHANGES:

  • updates in the markup
  • Search field is in fd-shellbar__group--actions group
  • fd-shellbar__title and fd-shellbar__subtitle elements are wrapped in fd-shellbar__product container

Before:

<span class="fd-shellbar__title">Corporate Portal</span>
<span class="fd-shellbar__subtitle">Solution name</span>

After:

<div class="fd-shellbar__product">
    <span class="fd-shellbar__title">Corporate Portal</span>
    <span class="fd-shellbar__subtitle">Solution name</span>
</div>
  • The logo and the product (title+subtitle) are wrapped in a new container with class fd-shellbar__branding

@InnaAtanasova InnaAtanasova requested a review from a team October 2, 2024 19:01
@InnaAtanasova InnaAtanasova self-assigned this Oct 2, 2024
@InnaAtanasova InnaAtanasova added the Horizon 2024 Horizon changes in 2024 label Oct 2, 2024
Copy link

netlify bot commented Oct 2, 2024

Deploy Preview for fundamental-styles ready!

Name Link
🔨 Latest commit 2f60b8c
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/66febab387243000089fc0cd
😎 Deploy Preview https://deploy-preview-5675--fundamental-styles.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@InnaAtanasova InnaAtanasova force-pushed the fix/shellbar-updates branch 3 times, most recently from ee978c2 to 477455f Compare October 2, 2024 20:18
@droshev droshev merged commit 065f5eb into main Oct 3, 2024
10 checks passed
@droshev droshev deleted the fix/shellbar-updates branch October 3, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Horizon 2024 Horizon changes in 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

shellbar design updates
2 participants