Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(styles): refactor Rating Indicator [ci visual] #5645

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(styles): refactor Rating Indicator [ci visual] #5645

wants to merge 2 commits into from

Conversation

InnaAtanasova
Copy link
Contributor

@InnaAtanasova InnaAtanasova commented Sep 17, 2024 •
edited
Loading

Related Issue

Closes #5634

Description

  • refactor markup to fulfil a11y requirements
  • use the latest design

BREAKING CHANGES:
new markup and classnames, complete refactor of Rating Indicator

@InnaAtanasova InnaAtanasova added A11y Accessibility concerns or improvements code refactoring labels Sep 17, 2024
@InnaAtanasova InnaAtanasova requested a review from a team September 17, 2024 19:51
@InnaAtanasova InnaAtanasova self-assigned this Sep 17, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 17, 2024 •
edited
Loading

✅ Deploy Preview for fundamental-styles ready!

Name Link
🔨 Latest commit 71b3071
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-styles/deploys/66eae8258886640008a8046d
😎 Deploy Preview https://deploy-preview-5645--fundamental-styles.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@InnaAtanasova InnaAtanasova changed the title fix(): refactor Rating Indicator [ci visual] [WIP]fix(styles): refactor Rating Indicator [ci visual] Sep 17, 2024
@InnaAtanasova InnaAtanasova changed the title [WIP]fix(styles): refactor Rating Indicator [ci visual] fix(styles): refactor Rating Indicator [ci visual] Sep 18, 2024
@droshev droshev self-requested a review September 30, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikerodonnell89 mikerodonnell89 mikerodonnell89 approved these changes

@droshev droshev droshev approved these changes

Assignees

@InnaAtanasova InnaAtanasova

Labels
A11y Accessibility concerns or improvements code refactoring
Projects
None yet
Milestone
Sprint 139 - October 2024
Development

Successfully merging this pull request may close these issues.

Rating Indicator Accessibility markup revisit
3 participants
@InnaAtanasova @mikerodonnell89 @droshev