Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform): Recheck loadingState before refocus table cell #12517

Open
wants to merge 1 commit into
base: ng-15-downport
Choose a base branch
from

Conversation

CSEHoangV
Copy link

@CSEHoangV CSEHoangV commented Oct 7, 2024

Related Issue(s)

closes #12450

Description

Issue: We have a listener on tableLoading to perform cell refocus whenever loadingState is false. However, this is executed asynchronously in setTimeout. Since table loading can be triggered either from internal or provided by application through [loading], there is a chance that it still runs when loadingState is true. For example, loadingState is set true from application when fetching the table and busy indicator is displayed on UI and scrollIntoView from focusCell will use busy indicator instead of table for position recalculation which gives the wrong position to scroll the table.

Solution: Add loadingState recheck to ensure that the code is only run when table is not loading.

@CSEHoangV CSEHoangV added the ng15 Angular 15 support label Oct 7, 2024
@CSEHoangV CSEHoangV self-assigned this Oct 7, 2024
Copy link

netlify bot commented Oct 7, 2024

Check the deploy log for errors here: https://app.netlify.com/sites/fundamental-ngx/deploys

Name Link
🔨 Latest commit f0b43b9
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/67035e2b4deffb000896c5d5

Copy link

github-actions bot commented Oct 7, 2024

Visit the preview URL for this PR (updated for commit f0b43b9):

https://fundamental-ngx-gh--pr12517-fix-ng15-platform-ta-btejmtgr.web.app

(expires Thu, 10 Oct 2024 04:39:32 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ng15 Angular 15 support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant