fix(platform): Combine Sorting, Filtering, and Grouping Settings into a Single Dialog #12502
Conversation
… filtering, and grouping dialogs into a single settings dialog.
dpavlenishvili
added
code refactoring
nice to have
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Visit the preview URL for this PR (updated for commit 830debb): https://fundamental-ngx-gh--pr12502-12441-table-settings-azujnm1u.web.app (expires Sun, 06 Oct 2024 11:26:43 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff |
dpavlenishvili
changed the title
droshev
changed the title
| <li | ||
| fd-list-item | ||
| [interactive]="true" | ||
| class="fd-list__item_cursor-pointer" |
There was a problem hiding this comment.
this should be fixed in fund-styles rather than adding a new class. If you want a temp fix better use dynamic style to add the cursor, something like:
[style.cursor]="interactive ? 'pointer' : 'auto'"
There was a problem hiding this comment.
I created a fix for this in Fd styles: SAP/fundamental-styles#5678
| effect( | ||
| () => { | ||
| const filteringData = this.filteringData(); | ||
| if (filteringData) { | ||
| this.filterBy.set([...filteringData.filterBy]); | ||
| this.viewSettingsFilters.set(filteringData.viewSettingsFilters); | ||
| this.columns.set(filteringData.columns); | ||
| } | ||
| }, | ||
| { allowSignalWrites: true } | ||
| ); |
There was a problem hiding this comment.
Angular strongly suggests against this approach. Have you tried achieving this with computed signals?
Related Issue(s)
closes #12441 #12447 #12181
Description
This PR refactors the TableViewSettingsDialogComponent to combine sorting, filtering, and grouping functionality into a single dialog. Previously, sorting, filtering, and grouping were handled by separate dialogs, but now they are merged for a more streamlined user experience. This also reduces code duplication and improves maintainability.
Key changes:
Screenshots
Before:
After:
Screen.Recording.2024-10-03.at.15.18.55.mov