[WIP] fix(core,platform): make headingLevel a shared type, use for table toolbar #12500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Visit the preview URL for this PR (updated for commit 79d25cd): https://fundamental-ngx-gh--pr12500-fix-11893-kh9bp4if.web.app (expires Mon, 07 Oct 2024 17:22:58 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff |
InnaAtanasova
requested changes
Oct 3, 2024
...ynamic-container-height-example/dynamic-page-dynamic-container-height-example.component.html
Outdated
Show resolved
Hide resolved
InnaAtanasova
requested changes
Oct 4, 2024
Comment on lines
138
to
140
| * The level of the Toolbar title | ||
| * Possible options: 'h1' | 'h2' | 'h3' | 'h4' | 'h5' | 'h6' | ||
| * Default: 'h2' |
There was a problem hiding this comment.
you need to update this
| * Default: 'h2' | ||
| */ | ||
| @Input() | ||
| headingLevel: HeadingLevel = 'h2'; |
Comment on lines
145
to
147
| * The level of the Toolbar title | ||
| * Possible options: 'h1' | 'h2' | 'h3' | 'h4' | 'h5' | 'h6' | ||
| * Default: 'h2' |
There was a problem hiding this comment.
this should be updated
| * Default: 'h2' | ||
| */ | ||
| @Input() | ||
| headingLevel: HeadingLevel = 'h2'; |
mikerodonnell89
changed the title
mikerodonnell89
changed the title
mikerodonnell89
changed the title
InnaAtanasova
approved these changes
Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #11893
A while ago @InnaAtanasova made the heading for dynamic page configurable. This takes the heading type and moves it to a shared folder, and makes the heading of table toolbar configurable in the same way as dynamic page.