Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cx): fix cx side bar keyboard navigation #12439

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Conversation

khotcholava
Copy link
Contributor

fix(cx): fix cx side bar keyboard navigation

closes #12337

Description

Refactor nested list component to improve performance and fix subscription bug

Before:

Old.example.mp4

After:

New.example.mp4

closes [#12337](#12337)

## Description
Refactor nested list component to improve performance and fix subscription bug
Copy link

netlify bot commented Sep 18, 2024

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit f6ace41
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/66f1642114ff4d0008ab7d1d
😎 Deploy Preview https://deploy-preview-12439--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Sep 18, 2024

Visit the preview URL for this PR (updated for commit f6ace41):

https://fundamental-ngx-gh--pr12439-fix-cx-side-nav-navi-bbnr39la.web.app

(expires Thu, 26 Sep 2024 12:55:14 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

@droshev droshev added this to the Sprint 138 - September 2024 milestone Sep 18, 2024
@droshev droshev added the cx label Sep 18, 2024
Copy link
Contributor

@dpavlenishvili dpavlenishvili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i requested changes for updating NestedListComponent

               closes (#12439)[#12439]

               ## Description
               - Removed manually subscription and implemented takeUntilDestroyed method
@khotcholava
Copy link
Contributor Author

@dpavlenishvili Ping

@droshev droshev merged commit 6169818 into main Sep 23, 2024
18 of 19 checks passed
@droshev droshev deleted the fix/cx-side-nav-navigation branch September 23, 2024 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cx SideNav - Keyboard navigation doesn't work if items are rendered conditionally or async
4 participants