Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): more customization of aria attributes for multi-input #12438

Merged
merged 3 commits into from
Sep 24, 2024
Merged

fix(core): more customization of aria attributes for multi-input #12438

merged 3 commits into from
Sep 24, 2024

Conversation

mikerodonnell89
Copy link
Member

fixes #12434

@mikerodonnell89 mikerodonnell89 requested a review from a team September 17, 2024 19:18
@mikerodonnell89 mikerodonnell89 self-assigned this Sep 17, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 17, 2024 •
edited
Loading

✅ Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit 908d5a6
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/66f1962f1de397000862d86d
😎 Deploy Preview https://deploy-preview-12438--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

Visit the preview URL for this PR (updated for commit 908d5a6):

https://fundamental-ngx-gh--pr12438-fix-12434-ng15-rfnezglr.web.app

(expires Fri, 27 Sep 2024 14:27:43 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

@droshev droshev added the ng15 Angular 15 support label Sep 18, 2024
dpavlenishvili
dpavlenishvili requested changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@dpavlenishvili dpavlenishvili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry i have to revert my approval, please see comment.

dpavlenishvili
dpavlenishvili reviewed Sep 19, 2024
View reviewed changes
libs/core/src/lib/multi-input/multi-input.component.html Outdated
@@ -49,9 +49,10 @@
[isExpanded]="open && !mobile && viewModel.displayedOptions.length > 0"
[isControl]="true"
[glyph]="showAddonButton ? glyph : ''"
[addonButtonAriaHidden]="!!title"
[addonButtonAriaHidden]="addonButtonAriaHidden"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

We have a common issue throughout the application where we use aria-hidden on focusable elements or elements with focusable children, which isn't allowed. In this case, the button is focusable and causes the error shown in the screenshot. I fixed a similar issue in my PR: #12445.
image

dpavlenishvili
dpavlenishvili requested changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@dpavlenishvili dpavlenishvili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please see the comment

@droshev
Copy link
Contributor

droshev commented Sep 19, 2024

@mikerodonnell89 Can you ask ariba's team to validate the change before merging it?

@mikerodonnell89
Copy link
Member Author

@mikerodonnell89 Can you ask ariba's team to validate the change before merging it?

can do

@mikerodonnell89 mikerodonnell89 merged commit 5b43f22 into ng-15-downport Sep 24, 2024
18 checks passed
@mikerodonnell89 mikerodonnell89 deleted the fix/12434-ng15 branch September 24, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khotcholava khotcholava khotcholava approved these changes

@dpavlenishvili dpavlenishvili dpavlenishvili approved these changes

Assignees

@mikerodonnell89 mikerodonnell89

Labels
ng15 Angular 15 support
Projects
None yet
Milestone
Sprint 138 - September 2024
Development

Successfully merging this pull request may close these issues.
4 participants
@mikerodonnell89 @droshev @khotcholava @dpavlenishvili