fix(platform): fdp-table Enhance the <fdp-table-p13-dialog [table]="table"> component to emit an event with the selected column #12430
+19
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes (#12293)[#12293] ## Description - Enhance the <fdp-table-p13-dialog [table]="table"></fdp-table-p13-dialog> component to emit an event with the selected column details when the OK button is clicked in the dialog. - This allows the application to subscribe to this event and persist the user’s selected columns.
✅ Deploy Preview for fundamental-ngx ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Visit the preview URL for this PR (updated for commit 341e7f4): https://fundamental-ngx-gh--pr12430-feat-emit-selected-c-x8y69a5b.web.app (expires Sat, 21 Sep 2024 08:54:23 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff |
khotcholava
changed the title
| @@ -78,6 +86,10 @@ export class TableP13DialogComponent implements OnDestroy { | |||
| return this._table; | |||
| } | |||
|
|
|||
| /** Event emitted when dialog is closed. */ | |||
| @Output() | |||
| closeDialog = new EventEmitter<string[]>(); | |||
There was a problem hiding this comment.
In my opinion, should be called dialogClosed, in past-tense, since it is an event that is triggered after closing. closeDialog gives me the impression it's a method that can be called that will then close the dialog
There was a problem hiding this comment.
Make sense, I've changed it.
mikerodonnell89
requested changes
Sep 16, 2024
libs/docs/platform/table/examples/platform-table-p13-columns-example.component.ts
Show resolved
Hide resolved
dpavlenishvili
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #12293
Description