Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement configuration for handling artifact ratings from a file #744

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sourabhsparkala
Copy link
Member

@sourabhsparkala sourabhsparkala commented Dec 1, 2021

Fixes #743 (duplicate)
Fixes #553

@sourabhsparkala sourabhsparkala added the enhancement New feature or request label Dec 1, 2021
@sourabhsparkala sourabhsparkala added this to the 1.5.0 milestone Dec 1, 2021
@sourabhsparkala sourabhsparkala self-assigned this Dec 1, 2021
Copy link
Member

@SebastianWolf-SAP SebastianWolf-SAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have to admit that I probably don't know enough of the whole codebase to really assess these considerably big changes properly. In addition, I don't have enough time in the next days to dig deeper here. 😞
Therefore, just a few remarks from my side that come to my mind:

@sourabhsparkala
Copy link
Member Author

I have to admit that I probably don't know enough of the whole codebase to really assess these considerably big changes properly. In addition, I don't have enough time in the next days to dig deeper here. 😞 Therefore, just a few remarks from my side that come to my mind:

You are right. I will find some time to update the document. Also, I will work on the test cases :)

@sourabhsparkala sourabhsparkala removed this from the 1.5.0 milestone Dec 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
2 participants