Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static pages for Business Accelerator Hub #525

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

newtork
Copy link
Contributor

@newtork newtork commented Aug 6, 2024

Context

SAP/cloud-sdk-java-backlog#457

We want an updated static page for generating type-safe clients with SAP Cloud SDK on Business Accelerator Hub.

In Reivew:

  • OData v2
  • OData v4
  • OpenAPI

Other:

  • Synced with JS SDK
  • Synced with B.A.H. colleagues

@newtork newtork added do not merge Pull request must not be merged please review Request to review a pull request labels Aug 6, 2024
@newtork newtork changed the title Initial OData v2 Static pages for Business Accelerator Hub Aug 6, 2024
Copy link
Contributor

@CharlesDuboisSAP CharlesDuboisSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only Minor comments, looks great!
Also:

  • Will the ✅ API Client generation tested but no download available note be removed?
  • Will the latest version of the generator be automatically updated?

docs/how-to/business-accelerator-hub-odatav2.md Outdated Show resolved Hide resolved
docs/how-to/business-accelerator-hub-odatav2.md Outdated Show resolved Hide resolved
docs/how-to/business-accelerator-hub-odatav2.md Outdated Show resolved Hide resolved
docs/how-to/business-accelerator-hub-odatav2.md Outdated Show resolved Hide resolved
@newtork
Copy link
Contributor Author

newtork commented Aug 6, 2024

  • Will the ✅ API Client generation tested but no download available note be removed?

Yes I expect everything on the right sidebar to be removed. Similar as is for ABAP.

  • Will the latest version of the generator be automatically updated?

No, unfortunately not.

We could investigate and pitch a JS script that updates the content on site-load by querying Maven Central. But chances for having that approved are probably low. GDPR does not allow for random third-party requests.

Copy link
Contributor

@CharlesDuboisSAP CharlesDuboisSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

docs/how-to/business-accelerator-hub-odatav4.md Outdated Show resolved Hide resolved
@newtork newtork marked this pull request as draft August 19, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge Pull request must not be merged please review Request to review a pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants