[SUCO] Add new object type SUCO #662
Conversation
|
|
|
|
| BEGIN OF ty_general_information, | ||
| "! <p class="shorttext">Application Default Variant Name</p> | ||
| "! Name of the authorization default variant | ||
| variant_name TYPE ty_var_name, | ||
| "! <p class="shorttext">Language Key for Short Text</p> | ||
| "! Language key for short text | ||
| language_key TYPE ty_language, | ||
| END OF ty_general_information. |
There was a problem hiding this comment.
You do not need to save the name of the object and the language key in the interface. The language key is already included in our header as originalLanguage and the name of the object is provided by our aff framework and is saved in the filename.
I would suggest removing variant_name and language_key from ty_general_information and instead move the contents of ty_leading_application here.
There was a problem hiding this comment.
I removed the whole type ty_general_information since we would like to keep the section “Leading Application” in the editor. Would that be okay?
There was a problem hiding this comment.
We have a naming convention for examples, can you please rename this file to z_aff_example_suco.suco.json? Please also update the link/name in the README.md.
There was a problem hiding this comment.
I have uploaded a new example (and README.md) with a name that complies with the convention.
| { | ||
| "formatVersion": "1", | ||
| "header": { | ||
| "description": "Apllication Default Variants", |
There was a problem hiding this comment.
| "description": "Apllication Default Variants", | |
| "description": "Application Default Variants", |
Is it only 1 variant? You wrote VariantS.
Additionally, what does SUCO stand for? Do you think it would make sense to write any reference to what SUCO stands for?
There was a problem hiding this comment.
Yes, only one authorization default variant is created or its short text is changed. I changed the texts and inserted one for the whole interface. Now they are more meaningful and singular.
No description provided.