Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EDCC] Add new object type for EDCC #661

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

KUMARMUKULSAP
Copy link
Contributor

No description provided.

Copy link

@GuilhermeSaraiva96 GuilhermeSaraiva96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thank you for your aff. Definitely one of the biggest I have seen :)

{
"formatVersion": "1",
"header": {
"description": "AFF type for EDCK",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"description": "AFF type for EDCK",
"description": "AFF type for EDCC",

What does EDCC stand for?

message_type_description TYPE ty_short_description,
"! <p class="shorttext">Tax Authority Document Type</p>
"! Tax authority document type
taxauth_documenttype TYPE c LENGTH 20,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tax_authority_document_type

"! <p class="shorttext">Tax Authority Document Type</p>
"! Tax authority document type
taxauth_documenttype TYPE c LENGTH 20,
original_language TYPE zif_aff_types_v1=>ty_original_language,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Messages must be in the same language as the system language. So, if the original Language of an EDCC is English and you opened the object in a German system, the messages shown to you will be a translation to German which are transported through a specific translation Transport Request. However, originally, they are in English. Since there is already an original language in the header of the AFF, no need for this field

Suggested change
original_language TYPE zif_aff_types_v1=>ty_original_language,

original_language TYPE zif_aff_types_v1=>ty_original_language,
END OF ty_message,
"! <p class="shorttext">Tax Authority Message Types</p>
"! Tax Authority Message types

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"! Tax Authority Message types
"! Tax authority message types

Sentence case

TYPES:
"! <p class="shorttext">Additional Tax Authority Table</p>
"! Additional tax authority table
BEGIN OF ty_taxauth_table,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
BEGIN OF ty_taxauth_table,
BEGIN OF ty_tax_authority_table,

ty_relationship_attributes TYPE SORTED TABLE OF ty_relationship_attribute WITH UNIQUE KEY
representation_type,
"! <p class="shorttext">eDocument Type Assignment</p>
"! Assign eDocument types associated with comsistency scenario

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"! Assign eDocument types associated with comsistency scenario
"! Assign eDocument types associated with consistency scenario

edoc_type TYPE c LENGTH 10,
END OF ty_edoc_type,
"! <p class="shorttext">eDocument Type Assignment</p>
"! Assign eDocument types associated with comsistency scenario

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"! Assign eDocument types associated with comsistency scenario
"! Assign eDocument types associated with consistency scenario

header TYPE zif_aff_types_v1=>ty_header_60_cloud,
"! <p class="shorttext">Country</p>
"! Country
country TYPE ty_country,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could include the type c length 3 directly here, there is no advantage in having ty_country defined outside the ty_main

country TYPE ty_country,
"! <p class="shorttext">Tax Authority Message Types</p>
"! Tax authority message types
taxauth_messages TYPE ty_messages,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
taxauth_messages TYPE ty_messages,
tax_authority_messages TYPE ty_messages,

taxauth_messages TYPE ty_messages,
"! <p class="shorttext">Additional Tax Authority Tables</p>
"! Additional tax authority tables
taxauth_tables TYPE ty_taxauth_tables,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
taxauth_tables TYPE ty_taxauth_tables,
tax_auth_tables TYPE ty_taxauth_tables,

@Markus1812 Markus1812 added the new-object This is a new object type added to AFF label Oct 1, 2024
@Markus1812 Markus1812 mentioned this pull request Oct 1, 2024
@KUMARMUKULSAP
Copy link
Contributor Author

@GuilhermeSaraiva96 : I have incorporated the above suggested changes. Please have a look and suggest if we can have a meeting to understand this AFF.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-object This is a new object type added to AFF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants