Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SAIA] Add new object type SAIA #614

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

uenal-akkaya
Copy link

No description provided.

@albertmink albertmink added the new-object This is a new object type added to AFF label May 21, 2024
@albertmink albertmink self-requested a review May 21, 2024 18:31
@albertmink
Copy link
Contributor

Hi Uenal,

the ENUM can solved like the abap language version over here
https://github.com/SAP/abap-file-formats/blob/main/file-formats/zif_aff_types_v1.intf.abap#L42-L55

@albertmink
Copy link
Contributor

Hi @uenal-akkaya,

we recommend to put the object specific part (in ty_main) into a separate type. Example:
https://github.com/SAP/abap-file-formats/blob/main/file-formats/sito/type/zif_aff_sito_v2.intf.abap#L568-L581

Copy link
Contributor

@wurzka wurzka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @uenal-akkaya,
thanks for your changes. See my comments. They are mainly related to naming issues.

file-formats/saia/type/zif_aff_saia_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/saia/type/zif_aff_saia_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/saia/type/zif_aff_saia_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/saia/type/zif_aff_saia_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/saia/type/zif_aff_saia_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/saia/type/zif_aff_saia_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/saia/type/zif_aff_saia_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/saia/type/zif_aff_saia_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/saia/type/zif_aff_saia_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/saia/type/zif_aff_saia_v1.intf.abap Outdated Show resolved Hide resolved
Copy link
Contributor

@wurzka wurzka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your changes. Looks good to me.

@wurzka wurzka requested a review from a team June 14, 2024 12:55
@albertmink albertmink marked this pull request as draft July 11, 2024 11:33
@albertmink
Copy link
Contributor

Set to draft as there will be still changes in the AFF.
@uenal-akkaya feel free, once you have the next increment, to set status to Ready for review.

@schneidermic0 schneidermic0 marked this pull request as ready for review October 1, 2024 08:40

File | Cardinality | Definition | Schema | Example
:--- | :--- | :--- | :--- | :---
`<name>.saia.json` | 1 | [`zif_aff_saia_v1.intf.abap`](./type/zif_aff_saia_v1.intf.abap) | [`saia-v1.json`](./saia-v1.json) | [`z_aff_example_saia.saia.json`](./examples/z_aff_example_saia.saia.json)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The abaplint check is working again, the link check is still failing, because an example is linked here, but the file z_aff_example_saia.saia.json is not included in this pull request. Maybe a git add is missing for the file?

@Markus1812 Markus1812 mentioned this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-object This is a new object type added to AFF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants