concrete error message if modules are not found #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
chgeo
reviewed
Aug 7, 2024
|
Looks good for me in general. |
bugwelle
reviewed
Aug 7, 2024
DanSchlachter
force-pushed
the
error-run-npm-ci
branch
from
79d5b94
to
baedfc8
Compare
…ud-cap-samples into error-run-npm-ci
…ud-cap-samples into error-run-npm-ci
Co-authored-by: Andre Meyering <[email protected]>
DanSchlachter
force-pushed
the
error-run-npm-ci
branch
from
baedfc8
to
6f1f93d
Compare
chgeo
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is the right approach.
Even though the readme.md states to run
npm cibeforecds w xxI was asked by several people struggling with the cap samples who get stuck atError: Cannot find module '@capire/bookshop/package.json'If you are used to cap projects working without npm i and not familiar with the workspace setup, you will run into this issue and don't necessarily understand why.