Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use database constraints #302

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

use database constraints #302

wants to merge 3 commits into from

Conversation

stewsk
Copy link
Contributor

@stewsk stewsk commented Dec 21, 2021

... in bookshop, orders, reviews

  • update package.json and package-lock.json as db constraints
    requires latest cds

... in bookshop, orders, reviews
+ update package.json and package-lock.json as db constraints
  requires latest cds
@stewsk stewsk requested review from danjoa and chgeo December 21, 2021 10:28
@stewsk
Copy link
Contributor Author

stewsk commented Feb 7, 2022

Hi @danjoa , any objections against switching on DB constraints in bookshop?

@danjoa
Copy link
Member

danjoa commented Feb 8, 2022

Good idea, we should do so 👍

reviews/package.json Outdated Show resolved Hide resolved
orders/package.json Outdated Show resolved Hide resolved
stewsk and others added 2 commits March 17, 2022 14:53
Co-authored-by: Patrice Bender <[email protected]>
Co-authored-by: Patrice Bender <[email protected]>
@@ -62,6 +62,22 @@ Authorization: Basic alice:
"currency": { "code": "USD" }
}

### ------------------------------------------------------------------------
# Create book with invalid author ID -> will fail
POST {{server}}/admin/Books

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could also add an example of where a ON DELETE CASCADE deletes leftover children?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants