Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use version number for dependency #483

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sidakphull
Copy link
Contributor

Not sure why but Kyma Deployment fails with the below error if we use tag instead of version:

node[28]: ../src/module_wrap.cc:599:v8::MaybeLocal<v8::Promise> 
node::loader::ImportModuleDynamically(v8::Local<v8::Context>, v8::Local<v8::Data>, v8::Local<v8::Value>, 
v8::Local<v8::String>, v8::Local<v8::FixedArray>): Assertion `(it) != (env->id_to_function_map.end())' failed.

@chgeo
Copy link
Member

chgeo commented Mar 21, 2023

@drktfl @stewsk how important is it that tags are used here instead of version numbers?

@chgeo chgeo requested review from drktfl and stewsk March 21, 2023 07:02
@stewsk
Copy link
Collaborator

stewsk commented Mar 21, 2023

Fiori colleagues recommended to use the tags instead of version number, but if that doesn't work with Kyma we can go back to version numbers.

@drktfl
Copy link
Member

drktfl commented Mar 21, 2023

This should be answered by someone from the tools team - but: Why do devDependencies play a role for deployment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants