-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examples for RAG Benchmarking - LLM as a judge #96
base: main
Are you sure you want to change the base?
Conversation
from rag_benchmark_utils.common_utils import create_retriever, validate_response, print_results | ||
from helpers.config import TERRAFORM_DOCS_TABLE_NAME | ||
|
||
RELATIVE_FILE_PATH = Path("data/golden_test_set.csv") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a must but might be easier to configure if moved to the config file
try: | ||
log.info(f"Asking question: {query}") | ||
result = qa_chain.invoke({"query": query}) | ||
actual_answer = result.get("result", "N/A") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again not a must but constants for N/A and Failed would be better in this scenario
multi_context: 0.4, | ||
reasoning: 0.1 | ||
} | ||
OUTPUT_PATH = Path('data/golden_test_set.csv') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a must but might be easier to configure if moved to the config file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small remarks but in general LGTM
This PR adds examples for 'RAG Benchmarking - LLM as a judge', as a new section.