Add a separate queue for querying PACS #503
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add a PixlOutOfHoursError that is raised by the pacs queue when out of hours
…PrimaryArchiveError error The consumer then sends the message to the secondary imaging queue. Only process messages in the secondary imaging queue outside of working hours. During working hours, re-queue the message
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #503 +/- ##
==========================================
- Coverage 87.78% 87.31% -0.48%
==========================================
Files 76 76
Lines 3415 3438 +23
==========================================
+ Hits 2998 3002 +4
- Misses 417 436 +19 ☔ View full report in Codecov by Sentry. |
stefpiatek
approved these changes
Sep 30, 2024
|
Oh also its worth checking the checklist in https://github.com/SAFEHR-data/the-rolling-skeleton/issues/416 to make sure that we've covered all of that |
…wo imaging api queues
…cuase the study is not in the VNA
stefpiatek
approved these changes
Oct 2, 2024
Comment on lines
+73
to
+74
| "imaging-primary": "imaging_api", | ||
| "imaging-secondary": "imaging_api", |
Comment on lines
123
to
127
| # We don't want to modify the queues we're populating, but if we're populating imaging-primary | ||
| # we also need to wait for imaging-secondary to be empty | ||
| queues_to_count = queues_to_populate.copy() | ||
| if "imaging-primary" in queues_to_populate and "imaging-secondary" not in queues_to_populate: | ||
| queues_to_count.append("imaging-secondary") |
There was a problem hiding this comment.
could make just make this a set and then add it to it without checking?
yeah good shout - I've set it running on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://github.com/SAFEHR-data/the-rolling-skeleton/issues/416
_imaging_secondary) for querying PACSimagingqueue will only query the VNA. If a study is not available in the VNA, the corresponding message will be published to the new secondary imaging queueType of change
Please delete options accordingly to the description.
Suggested Checklist
mainbranch.UCLH-Foundtry/arc-devsquash and merge