[IMPROVEMENT] Convert UTC to time #2077

VANKINEENITAWRUN · 2019-03-01T13:27:47Z

@RocketChat/android

Closes #2046

Changes: [converted the given UTC offset to time.]

Screenshots or GIF for the change:

CLAassistant · 2019-03-01T13:27:54Z

All committers have signed the CLA.

CLAassistant · 2019-03-01T13:27:54Z

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

philipbrito

Thanks for submitting this PR and closing the existent TODO here! But I think you could work with the Java 8 Date/Time API.

philipbrito

You can add a function on DateTimeHelper class to convert UTC to Time.

philipbrito · 2019-03-06T14:27:37Z

@VANKINEENITAWRUN Could you please sign in our CLA?

VANKINEENITAWRUN · 2019-03-06T14:51:12Z

I did @filipedelimabrito it's still pending.

RotBolt · 2019-03-18T15:22:39Z

app/src/main/java/chat/rocket/android/userdetails/presentation/UserDetailsPresenter.kt

+
+    fun utcToTime(utcOffset:Float?): String {
+        val gmtTime = System.currentTimeMillis() // 2.32pm NZDT
+        var timezoneAlteredTime: Long


You could Lift out the assignment timeZoneAlteredTime. Directly could
timeZoneAlteredTime = if (condition ) value else other value.
This would be according to Kotlin Coding style :)

convert UTC to Time

949a1e4

philipbrito reviewed Mar 4, 2019

View reviewed changes

philipbrito changed the title ~~convert UTC to Time~~ [NEW] Convert UTC to time Mar 4, 2019

philipbrito added the 👍 improvement label Mar 4, 2019

philipbrito changed the title ~~[NEW] Convert UTC to time~~ [IMPROVEMENT] Convert UTC to time Mar 4, 2019

philipbrito added this to the 3.3.0 milestone Mar 4, 2019

philipbrito reviewed Mar 5, 2019

View reviewed changes

VANKINEENITAWRUN and others added 2 commits March 5, 2019 19:43

added UTC to time function

c5dae85

Merge branch 'develop' into fix__timezone-userDetails

63d199c

RotBolt reviewed Mar 18, 2019

View reviewed changes

rafaelks removed this from the 3.3.0 milestone May 3, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[IMPROVEMENT] Convert UTC to time #2077

[IMPROVEMENT] Convert UTC to time #2077

VANKINEENITAWRUN commented Mar 1, 2019

CLAassistant commented Mar 1, 2019 •

edited

Loading

CLAassistant commented Mar 1, 2019

philipbrito left a comment

philipbrito left a comment

philipbrito commented Mar 6, 2019

VANKINEENITAWRUN commented Mar 6, 2019 •

edited

Loading

RotBolt Mar 18, 2019

[IMPROVEMENT] Convert UTC to time #2077

Are you sure you want to change the base?

[IMPROVEMENT] Convert UTC to time #2077

Conversation

VANKINEENITAWRUN commented Mar 1, 2019

Changes: [converted the given UTC offset to time.]

Screenshots or GIF for the change:

CLAassistant commented Mar 1, 2019 • edited Loading

CLAassistant commented Mar 1, 2019

philipbrito left a comment

Choose a reason for hiding this comment

philipbrito left a comment

Choose a reason for hiding this comment

philipbrito commented Mar 6, 2019

VANKINEENITAWRUN commented Mar 6, 2019 • edited Loading

RotBolt Mar 18, 2019

Choose a reason for hiding this comment

CLAassistant commented Mar 1, 2019 •

edited

Loading

VANKINEENITAWRUN commented Mar 6, 2019 •

edited

Loading