Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BillboardComponent #69

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

patrykantosz
Copy link
Contributor

Component that rotates the entity to ensure it always faces the target position.

michalpelka and others added 2 commits September 27, 2024 11:15
Signed-off-by: Patryk Antosz <[email protected]>
Co-authored-by: Patryk Antosz <[email protected]>
Signed-off-by: Patryk Antosz <[email protected]>
Copy link
Member

@pawelbudziszewski pawelbudziszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The component works as it should. I found one issue, however. Setting "Local Face To Billboard" works fine as long as Z is set to zero. Otherwise, the rotation works incorrectly:
billboard1

In the extreme case, if the "Local Face..." is set to [0,0,1], the billboard is not visible at all.
My suggestion would be to ignore the Z-axis in this case (always set it to 0). The rotation is always around the Z-axis, we should assume, that the object is aligned vertically.

@michalpelka
Copy link
Collaborator

I think we should retire this component and use AZSL shader material for that.

@pawelbudziszewski
Copy link
Member

I think we should retire this component and use AZSL shader material for that.

In general, I agree. However, what is the ETA for it? Maybe we should leave this one (it's already there) until the shader-based version is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants