Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pointcloud] Fixes in Pointcloud Gem #62

Merged
merged 6 commits into from
Sep 18, 2024
Merged

[Pointcloud] Fixes in Pointcloud Gem #62

merged 6 commits into from
Sep 18, 2024

Commits on Sep 5, 2024

  1. enable pointcloud bus for editor component 

    Signed-off-by: Mateusz Żak <[email protected]>
    @zakmat
    zakmat committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    a9c15ab View commit details
    Browse the repository at this point in the history

  2. clean up 

    * add comments
* clean up headers

Signed-off-by: Mateusz Żak <[email protected]>
    @zakmat
    zakmat committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    5338e09 View commit details
    Browse the repository at this point in the history

  3. query for featureProcessor before enable attempt 

    * this avoids flooding logs with warnings

Signed-off-by: Mateusz Żak <[email protected]>
    @zakmat
    zakmat committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    96c6232 View commit details
    Browse the repository at this point in the history

  4. do not apply transforms on invalid bounds 

    * it will make them valid - but incorrect

Signed-off-by: Mateusz Żak <[email protected]>
    @zakmat
    zakmat committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    856d22a View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2024

  1. further cleanup 

    * shorten the Gems Bus header filename

Signed-off-by: Mateusz Żak <[email protected]>
    @zakmat
    zakmat committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    86b6162 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2024

  1. Add ChangeEvent to PointcloudFeatureProcessor 

    * asset change should be signaled to the PointcloudController
* currently the change is needed to update cached local bounds to fix selection

Signed-off-by: Mateusz Żak <[email protected]>
    @zakmat
    zakmat committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    76d856a View commit details
    Browse the repository at this point in the history