-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The gem that allows to expose o3de to console to ROS 2 #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michał Pełka <[email protected]>
Signed-off-by: Michał Pełka <[email protected]>
michalpelka
force-pushed
the
mp/expose_console_gem
branch
from
August 21, 2024 15:24
928be21
to
3c3bc60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality looks correct, this gem should be used with caution. I suggest disabling the functionality all together, if build config is release
for security.
Note
Format the code
Gems/ExposeConsoleToRos/Code/Source/Clients/ExposeConsoleToRosSystemComponent.cpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Michał Pełka <[email protected]> Applied review Signed-off-by: Michał Pełka <[email protected]>
michalpelka
force-pushed
the
mp/expose_console_gem
branch
from
August 22, 2024 09:25
4db0d1a
to
b3b8b7f
Compare
I've make functionality available to Debug and Profile builds. |
Signed-off-by: Michał Pełka <[email protected]>
jhanca-robotecai
approved these changes
Sep 16, 2024
michalpelka
commented
Sep 17, 2024
Co-authored-by: Jan Hanca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is great tool for testing, terrible for production / automation.