Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The gem that allows to expose o3de to console to ROS 2 #59

Merged
merged 5 commits into from
Sep 17, 2024

Conversation

michalpelka
Copy link
Collaborator

It is great tool for testing, terrible for production / automation.

Signed-off-by: Michał Pełka <[email protected]>
Signed-off-by: Michał Pełka <[email protected]>
Copy link
Contributor

@MateuszWasilewski MateuszWasilewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks correct, this gem should be used with caution. I suggest disabling the functionality all together, if build config is release for security.

Note

Format the code

Signed-off-by: Michał Pełka <[email protected]>

Applied review

Signed-off-by: Michał Pełka <[email protected]>
@michalpelka
Copy link
Collaborator Author

I've make functionality available to Debug and Profile builds.

Signed-off-by: Michał Pełka <[email protected]>
Gems/ExposeConsoleToRos/gem.json Outdated Show resolved Hide resolved
Gems/ExposeConsoleToRos/gem.json Outdated Show resolved Hide resolved
@michalpelka michalpelka merged commit e745e1e into main Sep 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants