-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Smoothing gem #48
Smoothing gem #48
Conversation
9670951
to
bd24e65
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, smoothing component works as expected. Just some minor comments. Also I've noticed something strange - when I tried to enable this gem in my project I got something like this:
[ERROR] o3de.enable_gem: Smoothing has the following dependency compatibility issues and requires the --force parameter to activate: The following dependency requirements could not be satisfied: The project requires RobotecSpectatorCamera
It's strange becasue grep -rns ".*Spectator.*" ./Smoothing
returns empty list. Could you check this on your setup?
The gem allows user to smooth movement of the entity. It provides two types of smoothing: simple and damping. Co-authored-by: Patryk Antosz <[email protected]> Signed-off-by: Michał Pełka <[email protected]>
7474436
to
1a0805e
Compare
Thanks for review @patrykantosz ! I've updated PR, applied all your suggestions. I also squashed multiple commits. |
Are we going to merge it? |
Gem that allows to smooth movement of the entity.