Added support for loading CSV with WGS84 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalpelka
force-pushed
the
mp/csv_georeference
branch
from
c315f65
to
7a37f04
Compare
|
Interesting addition. The biggest issue I see is that the change introduces a dependency on a development branch of ROS2 Gem. I won't be able to use this Gem in projects that are based on released ROS2 Gems |
michalpelka
force-pushed
the
mp/csv_georeference
branch
2 times, most recently
from
c93620a
to
06294fd
Compare
pijaro
reviewed
Aug 8, 2024
Gems/RobotecSplineTools/Code/Source/Tools/SplineToolsEditorComponent.cpp
Outdated
Show resolved
Hide resolved
Gems/RobotecSplineTools/Code/Source/Tools/SplineToolsEditorComponent.cpp
Outdated
Show resolved
Hide resolved
Gems/RobotecSplineTools/Code/Source/Tools/SplineToolsEditorComponent.cpp
Outdated
Show resolved
Hide resolved
michalpelka
force-pushed
the
mp/csv_georeference
branch
from
b18a2f1
to
d581bf6
Compare
Signed-off-by: Michał Pełka <[email protected]>
michalpelka
force-pushed
the
mp/csv_georeference
branch
from
d581bf6
to
bc99023
Compare
Signed-off-by: Michał Pełka <[email protected]>
michalpelka
force-pushed
the
mp/csv_georeference
branch
from
bc99023
to
e37ff26
Compare
pijaro
requested changes
Sep 30, 2024
Signed-off-by: Michał Pełka <[email protected]>
|
@pijaro added. |
pijaro
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added way to import WGS84.
Omitted using o3de asset for handling filenames of CSV.